[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] hw/acpi: Always build the acpi/core.o file
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] hw/acpi: Always build the acpi/core.o file |
|
Date: |
Sat, 27 Apr 2019 19:00:12 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 4/27/19 6:55 PM, Philippe Mathieu-Daudé wrote:
> The 'core' ACPI functions are not X86-specific.
> Let this file be built unconditionally, this will allow
> us to use ACPI on non-X86 architectures.
>
> Suggested-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/acpi/Makefile.objs | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/acpi/Makefile.objs b/hw/acpi/Makefile.objs
> index c86edfbed90..09c810ac556 100644
> --- a/hw/acpi/Makefile.objs
> +++ b/hw/acpi/Makefile.objs
> @@ -1,4 +1,5 @@
> -common-obj-$(CONFIG_ACPI_X86) += core.o piix4.o pcihp.o
> +common-obj-$(CONFIG_ACPI) += core.o
Sorry, sent from wrong branch :S
Please consider reviewing with this snippet applied on top:
-- >8 --
diff --git a/hw/acpi/Makefile.objs b/hw/acpi/Makefile.objs
@@ -1,4 +1,4 @@
-common-obj-$(CONFIG_ACPI) += core.o
+common-obj-y += core.o
---
I'll respin after getting some review comments.
> +common-obj-$(CONFIG_ACPI_X86) += piix4.o pcihp.o
> common-obj-$(CONFIG_ACPI_X86_ICH) += ich9.o tco.o
> common-obj-$(CONFIG_ACPI_CPU_HOTPLUG) += cpu_hotplug.o
> common-obj-$(CONFIG_ACPI_MEMORY_HOTPLUG) += memory_hotplug.o
>