[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/i386: The i440fx is not a machine, remove it
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH] hw/i386: The i440fx is not a machine, remove it from the machine list |
Date: |
Sat, 27 Apr 2019 19:07:16 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 4/27/19 4:49 PM, Thomas Huth wrote:
> On 27/04/2019 16.19, Philippe Mathieu-Daudé wrote:
>> When building with CONFIG_ISAPC=n and CONFIG_I440FX=y we get:
>>
>> $ make subdir-x86_64-softmmu
>> [...]
>> /usr/bin/ld: hw/i386/pc_piix.o: in function `pc_init1':
>> /source/qemu/hw/i386/pc_piix.c:261: undefined reference to `isa_ide_init'
>> /usr/bin/ld: /source/qemu/hw/i386/pc_piix.c:261: undefined reference to
>> `isa_ide_init'
>> collect2: error: ld returned 1 exit status
>> make[1]: *** [Makefile:204: qemu-system-x86_64] Error 1
>>
>> This is because the I440FX device is a North Bridge, not a machine.
>
> Really? I thought CONFIG_I440FX was there to configure the
> "pc-i440fx-x.y" machine types?
Ah, I just found in hw/i386/pc_piix.c:
if (pcmc->pci_enabled) {
pci_bus = i440fx_init(host_type,
pci_type,
&i440fx_state, &piix3_devfn,
&isa_bus, pcms->gsi,
system_memory, system_io,
machine->ram_size,
pcms->below_4g_mem_size,
pcms->above_4g_mem_size,
pci_memory, ram_memory);
pcms->bus = pci_bus;
} else {
pci_bus = NULL;
i440fx_state = NULL;
isa_bus = isa_bus_new(NULL, get_system_memory(), system_io,
&error_abort);
no_hpet = 1;
}
So I guess I'll have to figure it out from here ;)
Thanks,
Phil.