[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 2/2] intel_iommu: Add support for translation for
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-ppc] [PATCH 2/2] intel_iommu: Add support for translation for devices behind bridges. |
Date: |
Sun, 26 Oct 2014 13:06:47 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2014-10-21 00:34, Knut Omang wrote:
> @@ -65,11 +66,12 @@ struct VTDContextCacheEntry {
> };
>
> struct VTDAddressSpace {
> - uint8_t bus_num;
> + PCIDevice *dev;
This change is not helpful for clean handling of non-PCI devices (i.e.
platform device interrupt remapping => you had to pull
Q35_PSEUDO_BUS_PLATFORM into intel_iommu, which is violating the
layering). Please leave bus_num in place - or convert to a 16-bit SID.
> uint8_t devfn;
> AddressSpace as;
> MemoryRegion iommu;
> IntelIOMMUState *iommu_state;
> + QLIST_ENTRY(VTDAddressSpace) iommu_next; /* For traversal by the iommu */
> VTDContextCacheEntry context_cache_entry;
> };
>
Jan
signature.asc
Description: OpenPGP digital signature
[Qemu-ppc] [PATCH 1/2] iommu: Replace bus+devfn arguments with PCIDevice* in PCIIOMMUFunc, Knut Omang, 2014/10/20
Re: [Qemu-ppc] [PATCH 0/2] intel_iommu: Add support for translation for devices behind bridges, Alexander Graf, 2014/10/20
- Re: [Qemu-ppc] [PATCH 0/2] intel_iommu: Add support for translation for devices behind bridges, Knut Omang, 2014/10/21
- Re: [Qemu-ppc] [PATCH 0/2] intel_iommu: Add support for translation for devices behind bridges, Alexander Graf, 2014/10/21
- Re: [Qemu-ppc] [PATCH 0/2] intel_iommu: Add support for translation for devices behind bridges, Knut Omang, 2014/10/21
- Re: [Qemu-ppc] [PATCH 0/2] intel_iommu: Add support for translation for devices behind bridges, Alexander Graf, 2014/10/21
- Re: [Qemu-ppc] [PATCH 0/2] intel_iommu: Add support for translation for devices behind bridges, Michael S. Tsirkin, 2014/10/21
- Re: [Qemu-ppc] [PATCH 0/2] intel_iommu: Add support for translation for devices behind bridges, Knut Omang, 2014/10/21