Re: [Qemu-ppc] [Qemu-devel] qemu-pcc 2.8.0 linux-user segfaults

[Peter Maydell]

On 30 January 2017 at 23:52, Sam Bobroff <address@hidden> wrote:
>> On 01/16/2017 03:56 PM, Aníbal Limón wrote:
>> > I'm trying to upgrade qemu to 2.8.0 in Openembedded-core and segfaults
>> > in qemu-ppc when is executing:

> I've recently encountered a similar problem and I've posted a fix. If
> you'd like to try it, it's here:
>
> https://lists.gnu.org/archive/html/qemu-ppc/2017-01/msg00413.html

Hmm, I missed that patch (it doesn't seem to have made it
to the qemu-devel list), but it isn't correct, I'm afraid.
In the patch for handling TARGET_USER_ESIGRETURN you must
not change the nip register, because we will have just
set it from the signal context that the guest provided
to the sigreturn syscall. (The patch as it stands will
cause us to reexecute an instruction after return from
a signal handler, which isn't going to go very well).

David, can you drop that patch from your ppc queue, please?

(I think the change is good otherwise but I couldn't
seem to find the bit in the ppc linux kernel that
corresponds to moving the NIP value around.)

thanks
-- PMM