[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PULL 000/107] ppc-for-2.9 queue 20170202
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PULL 000/107] ppc-for-2.9 queue 20170202 |
|
Date: |
Fri, 3 Feb 2017 09:36:18 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 02.02.2017 23:44, David Gibson wrote:
> On Wed, Feb 01, 2017 at 11:41:40PM -0800, address@hidden wrote:
>> Hi,
>>
>> Your series seems to have some coding style problems. See output below for
>> more information:
[...]
>> Checking PATCH 103/107: tcg/POWER9: NOOP the cp_abort instruction...
>> ERROR: do not use C99 // comments
>> #28: FILE: target/ppc/translate.c:6025:
>> + // Do Nothing
>>
>> total: 1 errors, 0 warnings, 17 lines checked
>>
>> Your patch has style problems, please review. If any of these errors
>> are false positives report them to the maintainer, see
>> CHECKPATCH in MAINTAINERS.
>
> But this one was me being sloppy. Do we care enough to re-do the
> pullreq?
We've got lot's of C++ comments in the QEMU sources already, and the
CODING_STYLE document even does not mention this ... maybe this is just
a left-over from the Linux kernel's checkpatch.pl script? So IMHO:
Ignore this error. (and if we really agree that C++ comments are a
no-go, then somebody should send a patch to update the CODING_STYLE).
Thomas
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-ppc] [Qemu-devel] [PULL 095/107] spapr: clock should count only if vm is running, (continued)
[Qemu-ppc] [PULL 078/107] target-ppc: Add xviexpdp instruction, David Gibson, 2017/02/02
[Qemu-ppc] [PULL 081/107] target-ppc: Add xvxsigsp instruction, David Gibson, 2017/02/02
[Qemu-ppc] [PULL 084/107] ppc/prep: update MAINTAINERS file, David Gibson, 2017/02/02
[Qemu-ppc] [PULL 085/107] ppc: Implement bcdtrunc. instruction, David Gibson, 2017/02/02
[Qemu-ppc] [PULL 101/107] target-ppc: Add xststdc[sp, dp, qp] instructions, David Gibson, 2017/02/02
[Qemu-ppc] [PULL 106/107] ppc/kvm: Handle the "family" CPU via alias instead of registering new types, David Gibson, 2017/02/02
Re: [Qemu-ppc] [Qemu-devel] [PULL 000/107] ppc-for-2.9 queue 20170202, no-reply, 2017/02/02
Re: [Qemu-ppc] [PULL 000/107] ppc-for-2.9 queue 20170202, Peter Maydell, 2017/02/03