[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PULL 5/6] spapr_drc: abort if object_property_add_child() fa
From: |
David Gibson |
Subject: |
[Qemu-ppc] [PULL 5/6] spapr_drc: abort if object_property_add_child() fails |
Date: |
Wed, 9 Aug 2017 17:03:56 +1000 |
From: Greg Kurz <address@hidden>
object_property_add_child() can only fail in two cases:
- the child already has a parent, which shouldn't happen since the DRC was
allocated a few lines above
- the parent already has a child with the same name, which would mean the
caller tries to create a DRC that already exists
In both case, this is a QEMU bug and we should abort.
Signed-off-by: Greg Kurz <address@hidden>
Signed-off-by: David Gibson <address@hidden>
---
hw/ppc/spapr_drc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c
index 47d94e782a..5260b5d363 100644
--- a/hw/ppc/spapr_drc.c
+++ b/hw/ppc/spapr_drc.c
@@ -541,7 +541,7 @@ sPAPRDRConnector *spapr_dr_connector_new(Object *owner,
const char *type,
drc->owner = owner;
prop_name = g_strdup_printf("dr-connector[%"PRIu32"]",
spapr_drc_index(drc));
- object_property_add_child(owner, prop_name, OBJECT(drc), NULL);
+ object_property_add_child(owner, prop_name, OBJECT(drc), &error_abort);
object_property_set_bool(OBJECT(drc), true, "realized", NULL);
g_free(prop_name);
--
2.13.4
- [Qemu-ppc] [PULL 0/6] ppc patch queue 2017-08-09, David Gibson, 2017/08/09
- [Qemu-ppc] [PULL 3/6] target/ppc: Implement TIDR, David Gibson, 2017/08/09
- [Qemu-ppc] [PULL 1/6] booke206: fix MAS update on tlb miss, David Gibson, 2017/08/09
- [Qemu-ppc] [PULL 5/6] spapr_drc: abort if object_property_add_child() fails,
David Gibson <=
- [Qemu-ppc] [PULL 6/6] spapr: Fix bug in h_signal_sys_reset(), David Gibson, 2017/08/09
- [Qemu-ppc] [PULL 4/6] target/ppc: Add stub implementation of the PSSCR, David Gibson, 2017/08/09
- [Qemu-ppc] [PULL 2/6] ppc: fix double-free in cpu_post_load(), David Gibson, 2017/08/09
- Re: [Qemu-ppc] [PULL 0/6] ppc patch queue 2017-08-09, Peter Maydell, 2017/08/10
- Re: [Qemu-ppc] [Qemu-devel] [PULL 0/6] ppc patch queue 2017-08-09, David Gibson, 2017/08/11
- Re: [Qemu-ppc] [Qemu-devel] [PULL 0/6] ppc patch queue 2017-08-09, Peter Maydell, 2017/08/11
- Re: [Qemu-ppc] [Qemu-devel] [PULL 0/6] ppc patch queue 2017-08-09, Philippe Mathieu-Daudé, 2017/08/11
- Re: [Qemu-ppc] [Qemu-devel] [PULL 0/6] ppc patch queue 2017-08-09, David Gibson, 2017/08/14
- Re: [Qemu-ppc] [Qemu-devel] [PULL 0/6] ppc patch queue 2017-08-09, Michael S. Tsirkin, 2017/08/14
- Re: [Qemu-ppc] [Qemu-devel] [PULL 0/6] ppc patch queue 2017-08-09, David Gibson, 2017/08/15