Re: [Qemu-riscv] [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
aefaa6d27f target/riscv: Remaining rvc insn reuse 32 bit translators
7d38b6a3a6 target/riscv: Splice remaining compressed insn pairs for riscv32 vs 
riscv64
e7c4cef989 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64
acd1bd17bc target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns
773c114e21 target/riscv: Convert @cs_2 insns to share translation functions
820409bf26 target/riscv: Remove decode_RV32_64G()
d9b6c4fbf1 target/riscv: Remove gen_system()
b710a729d4 target/riscv: Rename trans_arith to gen_arith
d0889eee71 target/riscv: Remove manual decoding of RV32/64M insn
13c3ed811a target/riscv: Remove shift and slt insn manual decoding
68260932ac target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists
c97f381c73 target/riscv: Move gen_arith_imm() decoding into trans_* functions
5f07685572 target/riscv: Remove manual decoding from gen_store()
06f8936794 target/riscv: Remove manual decoding from gen_load()
fcffa51cc7 target/riscv: Remove manual decoding from gen_branch()
71d2bfc56a target/riscv: Remove gen_jalr()
67acb3a13a target/riscv: Convert quadrant 2 of RVXC insns to decodetree
667b7025a2 target/riscv: Convert quadrant 1 of RVXC insns to decodetree
a6a54cd665 target/riscv: Convert quadrant 0 of RVXC insns to decodetree
aaafc94d51 target/riscv: Convert RV priv insns to decodetree
93022dd55c target/riscv: Convert RV64D insns to decodetree
d1161d5230 target/riscv: Convert RV32D insns to decodetree
3e90fd0856 target/riscv: Convert RV64F insns to decodetree
59864b1685 target/riscv: Convert RV32F insns to decodetree
3a2c5f541d target/riscv: Convert RV64A insns to decodetree
f82abf658a target/riscv: Convert RV32A insns to decodetree
ab048656b6 target/riscv: Convert RVXM insns to decodetree
111f67b3e7 target/riscv: Convert RVXI csr insns to decodetree
c396660ebe target/riscv: Convert RVXI fence insns to decodetree
39398bc39f target/riscv: Convert RVXI arithmetic insns to decodetree
7992aaf172 target/riscv: Convert RV64I load/store insns to decodetree
442919643f target/riscv: Convert RV32I load/store insns to decodetree
a06aff74df target/riscv: Convert RVXI branch insns to decodetree
be6c9c1db2 target/riscv: Activate decodetree and implemnt LUI & AUIPC

=== OUTPUT BEGIN ===
1/34 Checking commit be6c9c1db2eb (target/riscv: Activate decodetree and 
implemnt LUI & AUIPC)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
new file mode 100644

ERROR: externs should be avoided in .c files
#125: FILE: target/riscv/translate.c:1884:
+bool decode_insn32(DisasContext *ctx, uint32_t insn);

total: 1 errors, 1 warnings, 125 lines checked

Patch 1/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/34 Checking commit a06aff74df2b (target/riscv: Convert RVXI branch insns to 
decodetree)
3/34 Checking commit 442919643fdd (target/riscv: Convert RV32I load/store insns 
to decodetree)
4/34 Checking commit 7992aaf1722d (target/riscv: Convert RV64I load/store insns 
to decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39: 
new file mode 100644

total: 0 errors, 1 warnings, 76 lines checked

Patch 4/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/34 Checking commit 39398bc39fe4 (target/riscv: Convert RVXI arithmetic insns 
to decodetree)
6/34 Checking commit c396660ebe10 (target/riscv: Convert RVXI fence insns to 
decodetree)
7/34 Checking commit 111f67b3e707 (target/riscv: Convert RVXI csr insns to 
decodetree)
8/34 Checking commit ab048656b681 (target/riscv: Convert RVXM insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 169 lines checked

Patch 8/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/34 Checking commit f82abf658aad (target/riscv: Convert RV32A insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

total: 0 errors, 1 warnings, 199 lines checked

Patch 9/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/34 Checking commit 3a2c5f541dfc (target/riscv: Convert RV64A insns to 
decodetree)
11/34 Checking commit 59864b16854b (target/riscv: Convert RV32F insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#78: 
new file mode 100644

total: 0 errors, 1 warnings, 442 lines checked

Patch 11/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/34 Checking commit 3e90fd0856c1 (target/riscv: Convert RV64F insns to 
decodetree)
13/34 Checking commit d1161d52309a (target/riscv: Convert RV32D insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#51: 
new file mode 100644

total: 0 errors, 1 warnings, 398 lines checked

Patch 13/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/34 Checking commit 93022dd55c16 (target/riscv: Convert RV64D insns to 
decodetree)
15/34 Checking commit aaafc94d51e5 (target/riscv: Convert RV priv insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41: 
new file mode 100644

total: 0 errors, 1 warnings, 214 lines checked

Patch 15/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/34 Checking commit a6a54cd66584 (target/riscv: Convert quadrant 0 of RVXC 
insns to decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

ERROR: externs should be avoided in .c files
#251: FILE: target/riscv/translate.c:1072:
+bool decode_insn16(DisasContext *ctx, uint16_t insn);

total: 1 errors, 1 warnings, 231 lines checked

Patch 16/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

17/34 Checking commit 667b7025a214 (target/riscv: Convert quadrant 1 of RVXC 
insns to decodetree)
18/34 Checking commit 67acb3a13a99 (target/riscv: Convert quadrant 2 of RVXC 
insns to decodetree)
19/34 Checking commit 71d2bfc56aa4 (target/riscv: Remove gen_jalr())
20/34 Checking commit fcffa51cc7f8 (target/riscv: Remove manual decoding from 
gen_branch())
21/34 Checking commit 06f8936794fb (target/riscv: Remove manual decoding from 
gen_load())
22/34 Checking commit 5f076855726a (target/riscv: Remove manual decoding from 
gen_store())
23/34 Checking commit c97f381c73ba (target/riscv: Move gen_arith_imm() decoding 
into trans_* functions)
24/34 Checking commit 68260932acb5 (target/riscv: make ADD/SUB/OR/XOR/AND insn 
use arg lists)
25/34 Checking commit 13c3ed811adb (target/riscv: Remove shift and slt insn 
manual decoding)
26/34 Checking commit d0889eee7120 (target/riscv: Remove manual decoding of 
RV32/64M insn)
27/34 Checking commit b710a729d453 (target/riscv: Rename trans_arith to 
gen_arith)
28/34 Checking commit d9b6c4fbf13d (target/riscv: Remove gen_system())
29/34 Checking commit 820409bf26c8 (target/riscv: Remove decode_RV32_64G())
30/34 Checking commit 773c114e215d (target/riscv: Convert @cs_2 insns to share 
translation functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#42: 
new file mode 100644

ERROR: externs should be avoided in .c files
#182: FILE: target/riscv/translate.c:548:
+bool decode_insn16(DisasContext *ctx, uint16_t insn);

total: 1 errors, 1 warnings, 164 lines checked

Patch 30/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

31/34 Checking commit acd1bd17bca6 (target/riscv: Convert @cl_d, @cl_w, @cs_d, 
@cs_w insns)
32/34 Checking commit e7c4cef989c4 (target/riscv: Splice fsw_sd and flw_ld for 
riscv32 vs riscv64)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

total: 0 errors, 1 warnings, 309 lines checked

Patch 32/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
33/34 Checking commit 7d38b6a3a6ee (target/riscv: Splice remaining compressed 
insn pairs for riscv32 vs riscv64)
34/34 Checking commit aefaa6d27f88 (target/riscv: Remaining rvc insn reuse 32 
bit translators)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden