Re: [Qemu-riscv] [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
3b9d37e069 target/riscv: Remaining rvc insn reuse 32 bit translators
9fe8c74651 target/riscv: Splice remaining compressed insn pairs for riscv32 vs 
riscv64
f0d42e11ed target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64
6372447bab target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns
fbfdca289f target/riscv: Convert @cs_2 insns to share translation functions
9b1f13fef0 target/riscv: Remove decode_RV32_64G()
e1b04f5631 target/riscv: Remove gen_system()
0cf15d4fde target/riscv: Rename trans_arith to gen_arith
4476739bb6 target/riscv: Remove manual decoding of RV32/64M insn
9c74a64743 target/riscv: Remove shift and slt insn manual decoding
0712e5d505 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists
e576b335a3 target/riscv: Move gen_arith_imm() decoding into trans_* functions
411a0657a5 target/riscv: Remove manual decoding from gen_store()
847027c8df target/riscv: Remove manual decoding from gen_load()
4d09f89815 target/riscv: Remove manual decoding from gen_branch()
a2e6e2a506 target/riscv: Remove gen_jalr()
745647749f target/riscv: Convert quadrant 2 of RVXC insns to decodetree
620e151c96 target/riscv: Convert quadrant 1 of RVXC insns to decodetree
c65c33204a target/riscv: Convert quadrant 0 of RVXC insns to decodetree
7496f66eea target/riscv: Convert RV priv insns to decodetree
f8def66abe target/riscv: Convert RV64D insns to decodetree
b09c15290d target/riscv: Convert RV32D insns to decodetree
73fa49c40e target/riscv: Convert RV64F insns to decodetree
031e9b105b target/riscv: Convert RV32F insns to decodetree
568deed796 target/riscv: Convert RV64A insns to decodetree
439771055d target/riscv: Convert RV32A insns to decodetree
9f1a2b333f target/riscv: Convert RVXM insns to decodetree
67032b74c5 target/riscv: Convert RVXI csr insns to decodetree
248c9cbbab target/riscv: Convert RVXI fence insns to decodetree
73c1e54c41 target/riscv: Convert RVXI arithmetic insns to decodetree
082d0d36e5 target/riscv: Convert RV64I load/store insns to decodetree
f2abcccebe target/riscv: Convert RV32I load/store insns to decodetree
3b85b9c661 target/riscv: Convert RVXI branch insns to decodetree
685654f547 target/riscv: Activate decodetree and implemnt LUI & AUIPC

=== OUTPUT BEGIN ===
1/34 Checking commit 685654f547cf (target/riscv: Activate decodetree and 
implemnt LUI & AUIPC)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
new file mode 100644

ERROR: externs should be avoided in .c files
#125: FILE: target/riscv/translate.c:1884:
+bool decode_insn32(DisasContext *ctx, uint32_t insn);

total: 1 errors, 1 warnings, 125 lines checked

Patch 1/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/34 Checking commit 3b85b9c661bd (target/riscv: Convert RVXI branch insns to 
decodetree)
3/34 Checking commit f2abcccebece (target/riscv: Convert RV32I load/store insns 
to decodetree)
4/34 Checking commit 082d0d36e5d8 (target/riscv: Convert RV64I load/store insns 
to decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39: 
new file mode 100644

total: 0 errors, 1 warnings, 76 lines checked

Patch 4/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/34 Checking commit 73c1e54c4106 (target/riscv: Convert RVXI arithmetic insns 
to decodetree)
6/34 Checking commit 248c9cbbab67 (target/riscv: Convert RVXI fence insns to 
decodetree)
7/34 Checking commit 67032b74c569 (target/riscv: Convert RVXI csr insns to 
decodetree)
8/34 Checking commit 9f1a2b333f8b (target/riscv: Convert RVXM insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 169 lines checked

Patch 8/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/34 Checking commit 439771055d06 (target/riscv: Convert RV32A insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

total: 0 errors, 1 warnings, 199 lines checked

Patch 9/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/34 Checking commit 568deed7965c (target/riscv: Convert RV64A insns to 
decodetree)
11/34 Checking commit 031e9b105b76 (target/riscv: Convert RV32F insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#78: 
new file mode 100644

total: 0 errors, 1 warnings, 442 lines checked

Patch 11/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/34 Checking commit 73fa49c40e16 (target/riscv: Convert RV64F insns to 
decodetree)
13/34 Checking commit b09c15290d31 (target/riscv: Convert RV32D insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#51: 
new file mode 100644

total: 0 errors, 1 warnings, 398 lines checked

Patch 13/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/34 Checking commit f8def66abe0a (target/riscv: Convert RV64D insns to 
decodetree)
15/34 Checking commit 7496f66eea0e (target/riscv: Convert RV priv insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41: 
new file mode 100644

total: 0 errors, 1 warnings, 214 lines checked

Patch 15/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/34 Checking commit c65c33204ac4 (target/riscv: Convert quadrant 0 of RVXC 
insns to decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

ERROR: externs should be avoided in .c files
#251: FILE: target/riscv/translate.c:1072:
+bool decode_insn16(DisasContext *ctx, uint16_t insn);

total: 1 errors, 1 warnings, 231 lines checked

Patch 16/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

17/34 Checking commit 620e151c96f5 (target/riscv: Convert quadrant 1 of RVXC 
insns to decodetree)
18/34 Checking commit 745647749f25 (target/riscv: Convert quadrant 2 of RVXC 
insns to decodetree)
19/34 Checking commit a2e6e2a506d5 (target/riscv: Remove gen_jalr())
20/34 Checking commit 4d09f89815f6 (target/riscv: Remove manual decoding from 
gen_branch())
21/34 Checking commit 847027c8df72 (target/riscv: Remove manual decoding from 
gen_load())
22/34 Checking commit 411a0657a555 (target/riscv: Remove manual decoding from 
gen_store())
23/34 Checking commit e576b335a339 (target/riscv: Move gen_arith_imm() decoding 
into trans_* functions)
24/34 Checking commit 0712e5d505d3 (target/riscv: make ADD/SUB/OR/XOR/AND insn 
use arg lists)
25/34 Checking commit 9c74a6474389 (target/riscv: Remove shift and slt insn 
manual decoding)
26/34 Checking commit 4476739bb651 (target/riscv: Remove manual decoding of 
RV32/64M insn)
27/34 Checking commit 0cf15d4fdebf (target/riscv: Rename trans_arith to 
gen_arith)
28/34 Checking commit e1b04f563128 (target/riscv: Remove gen_system())
29/34 Checking commit 9b1f13fef020 (target/riscv: Remove decode_RV32_64G())
30/34 Checking commit fbfdca289f1b (target/riscv: Convert @cs_2 insns to share 
translation functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#42: 
new file mode 100644

ERROR: externs should be avoided in .c files
#182: FILE: target/riscv/translate.c:548:
+bool decode_insn16(DisasContext *ctx, uint16_t insn);

total: 1 errors, 1 warnings, 164 lines checked

Patch 30/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

31/34 Checking commit 6372447babca (target/riscv: Convert @cl_d, @cl_w, @cs_d, 
@cs_w insns)
32/34 Checking commit f0d42e11ed0d (target/riscv: Splice fsw_sd and flw_ld for 
riscv32 vs riscv64)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

total: 0 errors, 1 warnings, 309 lines checked

Patch 32/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
33/34 Checking commit 9fe8c746511d (target/riscv: Splice remaining compressed 
insn pairs for riscv32 vs riscv64)
34/34 Checking commit 3b9d37e069c1 (target/riscv: Remaining rvc insn reuse 32 
bit translators)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden