Re: [Qemu-riscv] [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
575e951e3b target/riscv: Remaining rvc insn reuse 32 bit translators
145f2de704 target/riscv: Splice remaining compressed insn pairs for riscv32 vs 
riscv64
488a3dbd5b target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64
1a22ffc51d target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns
c1cb5fe305 target/riscv: Convert @cs_2 insns to share translation functions
c0ed712696 target/riscv: Remove decode_RV32_64G()
33fb27a103 target/riscv: Remove gen_system()
526ce18f70 target/riscv: Rename trans_arith to gen_arith
31197b635d target/riscv: Remove manual decoding of RV32/64M insn
e3be11df5a target/riscv: Remove shift and slt insn manual decoding
1f50bd6713 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists
966a93a77d target/riscv: Move gen_arith_imm() decoding into trans_* functions
18b2204791 target/riscv: Remove manual decoding from gen_store()
8391fd64e7 target/riscv: Remove manual decoding from gen_load()
1a4878abc1 target/riscv: Remove manual decoding from gen_branch()
e9185ddceb target/riscv: Remove gen_jalr()
f3e2629027 target/riscv: Convert quadrant 2 of RVXC insns to decodetree
5ccf0cbbe3 target/riscv: Convert quadrant 1 of RVXC insns to decodetree
33c2fb427f target/riscv: Convert quadrant 0 of RVXC insns to decodetree
fad9363d56 target/riscv: Convert RV priv insns to decodetree
e6ed80e3a3 target/riscv: Convert RV64D insns to decodetree
a42295749f target/riscv: Convert RV32D insns to decodetree
a52f605ff0 target/riscv: Convert RV64F insns to decodetree
4b8cec3579 target/riscv: Convert RV32F insns to decodetree
3358c9735f target/riscv: Convert RV64A insns to decodetree
542959299f target/riscv: Convert RV32A insns to decodetree
1489475225 target/riscv: Convert RVXM insns to decodetree
3a445c5718 target/riscv: Convert RVXI csr insns to decodetree
ec1bad37be target/riscv: Convert RVXI fence insns to decodetree
863a74e1c1 target/riscv: Convert RVXI arithmetic insns to decodetree
c872667ddf target/riscv: Convert RV64I load/store insns to decodetree
909f6cd5d6 target/riscv: Convert RV32I load/store insns to decodetree
df16d51e9c target/riscv: Convert RVXI branch insns to decodetree
85516cfa42 target/riscv: Activate decodetree and implemnt LUI & AUIPC

=== OUTPUT BEGIN ===
1/34 Checking commit 85516cfa42f3 (target/riscv: Activate decodetree and 
implemnt LUI & AUIPC)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
new file mode 100644

ERROR: externs should be avoided in .c files
#125: FILE: target/riscv/translate.c:1884:
+bool decode_insn32(DisasContext *ctx, uint32_t insn);

total: 1 errors, 1 warnings, 125 lines checked

Patch 1/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/34 Checking commit df16d51e9c94 (target/riscv: Convert RVXI branch insns to 
decodetree)
3/34 Checking commit 909f6cd5d657 (target/riscv: Convert RV32I load/store insns 
to decodetree)
4/34 Checking commit c872667ddf92 (target/riscv: Convert RV64I load/store insns 
to decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39: 
new file mode 100644

total: 0 errors, 1 warnings, 76 lines checked

Patch 4/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/34 Checking commit 863a74e1c1d1 (target/riscv: Convert RVXI arithmetic insns 
to decodetree)
6/34 Checking commit ec1bad37be50 (target/riscv: Convert RVXI fence insns to 
decodetree)
7/34 Checking commit 3a445c571840 (target/riscv: Convert RVXI csr insns to 
decodetree)
8/34 Checking commit 1489475225b9 (target/riscv: Convert RVXM insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 169 lines checked

Patch 8/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/34 Checking commit 542959299f3e (target/riscv: Convert RV32A insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

total: 0 errors, 1 warnings, 199 lines checked

Patch 9/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/34 Checking commit 3358c9735ff5 (target/riscv: Convert RV64A insns to 
decodetree)
11/34 Checking commit 4b8cec35790a (target/riscv: Convert RV32F insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#78: 
new file mode 100644

total: 0 errors, 1 warnings, 442 lines checked

Patch 11/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/34 Checking commit a52f605ff062 (target/riscv: Convert RV64F insns to 
decodetree)
13/34 Checking commit a42295749f72 (target/riscv: Convert RV32D insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#51: 
new file mode 100644

total: 0 errors, 1 warnings, 398 lines checked

Patch 13/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/34 Checking commit e6ed80e3a32a (target/riscv: Convert RV64D insns to 
decodetree)
15/34 Checking commit fad9363d563d (target/riscv: Convert RV priv insns to 
decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#41: 
new file mode 100644

total: 0 errors, 1 warnings, 214 lines checked

Patch 15/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/34 Checking commit 33c2fb427f6b (target/riscv: Convert quadrant 0 of RVXC 
insns to decodetree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

ERROR: externs should be avoided in .c files
#251: FILE: target/riscv/translate.c:1072:
+bool decode_insn16(DisasContext *ctx, uint16_t insn);

total: 1 errors, 1 warnings, 231 lines checked

Patch 16/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

17/34 Checking commit 5ccf0cbbe376 (target/riscv: Convert quadrant 1 of RVXC 
insns to decodetree)
18/34 Checking commit f3e2629027f0 (target/riscv: Convert quadrant 2 of RVXC 
insns to decodetree)
19/34 Checking commit e9185ddceb45 (target/riscv: Remove gen_jalr())
20/34 Checking commit 1a4878abc19a (target/riscv: Remove manual decoding from 
gen_branch())
21/34 Checking commit 8391fd64e77d (target/riscv: Remove manual decoding from 
gen_load())
22/34 Checking commit 18b220479121 (target/riscv: Remove manual decoding from 
gen_store())
23/34 Checking commit 966a93a77d52 (target/riscv: Move gen_arith_imm() decoding 
into trans_* functions)
24/34 Checking commit 1f50bd67136c (target/riscv: make ADD/SUB/OR/XOR/AND insn 
use arg lists)
25/34 Checking commit e3be11df5aec (target/riscv: Remove shift and slt insn 
manual decoding)
26/34 Checking commit 31197b635d05 (target/riscv: Remove manual decoding of 
RV32/64M insn)
27/34 Checking commit 526ce18f70e2 (target/riscv: Rename trans_arith to 
gen_arith)
28/34 Checking commit 33fb27a10390 (target/riscv: Remove gen_system())
29/34 Checking commit c0ed71269686 (target/riscv: Remove decode_RV32_64G())
30/34 Checking commit c1cb5fe30514 (target/riscv: Convert @cs_2 insns to share 
translation functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#42: 
new file mode 100644

ERROR: externs should be avoided in .c files
#182: FILE: target/riscv/translate.c:548:
+bool decode_insn16(DisasContext *ctx, uint16_t insn);

total: 1 errors, 1 warnings, 164 lines checked

Patch 30/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

31/34 Checking commit 1a22ffc51d45 (target/riscv: Convert @cl_d, @cl_w, @cs_d, 
@cs_w insns)
32/34 Checking commit 488a3dbd5b3d (target/riscv: Splice fsw_sd and flw_ld for 
riscv32 vs riscv64)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

total: 0 errors, 1 warnings, 309 lines checked

Patch 32/34 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
33/34 Checking commit 145f2de704e7 (target/riscv: Splice remaining compressed 
insn pairs for riscv32 vs riscv64)
34/34 Checking commit 575e951e3bab (target/riscv: Remaining rvc insn reuse 32 
bit translators)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden