[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH v2 7/8] qtest: Don't reset on qtest chardev con
From: |
Andreas Färber |
Subject: |
Re: [Qemu-stable] [PATCH v2 7/8] qtest: Don't reset on qtest chardev connect |
Date: |
Fri, 22 Feb 2013 18:24:12 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 |
Am 22.02.2013 18:20, schrieb Markus Armbruster:
> libqtest's qtest_init() connecting to the qtest socket triggers reset.
> This was coded in the hope we could use the same QEMU process for
> multiple tests that way. Never used. Injects an extra reset even
> when it's not used, and that can mess up tests such as the one of
> -boot once I'm about to add. Drop it.
>
> Signed-off-by: Markus Armbruster <address@hidden>
Acked-by: Andreas Färber <address@hidden>
Thanks,
Andreas
> ---
> qtest.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/qtest.c b/qtest.c
> index 5e0e9ec..e5b1b11 100644
> --- a/qtest.c
> +++ b/qtest.c
> @@ -472,7 +472,12 @@ static void qtest_event(void *opaque, int event)
>
> switch (event) {
> case CHR_EVENT_OPENED:
> - qemu_system_reset(false);
> + /*
> + * We used to call qemu_system_reset() here, hoping we could
> + * use the same process for multiple tests that way. Never
> + * used. Injects an extra reset even when it's not used, and
> + * that can mess up tests, e.g. -boot once.
> + */
> for (i = 0; i < ARRAY_SIZE(irq_levels); i++) {
> irq_levels[i] = 0;
> }
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-stable] [PATCH v2 0/8] -boot and -no-fd-bootchk fixes, Markus Armbruster, 2013/02/22
- [Qemu-stable] [PATCH v2 2/8] qemu-option: check_params() is now unused, drop it, Markus Armbruster, 2013/02/22
- [Qemu-stable] [PATCH v2 3/8] vl: Fix -boot order and once regressions, and related bugs, Markus Armbruster, 2013/02/22
- [Qemu-stable] [PATCH v2 1/8] vl: Clean up parsing of -boot option argument, Markus Armbruster, 2013/02/22
- [Qemu-stable] [PATCH v2 4/8] vl: Rename *boot_devices to *boot_order, for consistency, Markus Armbruster, 2013/02/22
- [Qemu-stable] [PATCH v2 5/8] pc: Make -no-fd-bootchk stick across boot order changes, Markus Armbruster, 2013/02/22
- [Qemu-stable] [PATCH v2 6/8] pc: Drop ref to Bochs from -no-fd-bootchk documentation, Markus Armbruster, 2013/02/22
- [Qemu-stable] [PATCH v2 7/8] qtest: Don't reset on qtest chardev connect, Markus Armbruster, 2013/02/22
- Re: [Qemu-stable] [PATCH v2 7/8] qtest: Don't reset on qtest chardev connect,
Andreas Färber <=
- [Qemu-stable] [PATCH v2 8/8] qtest: Add boot order test, Markus Armbruster, 2013/02/22