[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH v2 8/8] qtest: Add boot order test
From: |
Andreas Färber |
Subject: |
Re: [Qemu-stable] [PATCH v2 8/8] qtest: Add boot order test |
Date: |
Fri, 22 Feb 2013 18:31:36 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 |
Am 22.02.2013 18:20, schrieb Markus Armbruster:
> Covers only PC so far.
>
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Andreas Färber <address@hidden>
> +static void test_cmos_byte(int reg, int expected)
> +{
> + int actual;
> +
> + outb(0x70 + 0, reg);
> + actual = inb(0x71);
Did you intend to use 0x70 + 1 here or why the 0x70 + 0 above?
> + g_assert_cmphex(actual, ==, expected);
> +}
> +int main(int argc, char *argv[])
> +{
> + g_test_init(&argc, &argv, NULL);
> +
> + qtest_add_func("boot-order/pc", test_pc_boot_order);
> +
> + return g_test_run();
> +}
So this is suggesting to me to add separate test functions per arch.
Fine with me, we'll only have to reindent one line then.
Thanks for the changes,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-stable] [PATCH v2 0/8] -boot and -no-fd-bootchk fixes, Markus Armbruster, 2013/02/22
- [Qemu-stable] [PATCH v2 2/8] qemu-option: check_params() is now unused, drop it, Markus Armbruster, 2013/02/22
- [Qemu-stable] [PATCH v2 3/8] vl: Fix -boot order and once regressions, and related bugs, Markus Armbruster, 2013/02/22
- [Qemu-stable] [PATCH v2 1/8] vl: Clean up parsing of -boot option argument, Markus Armbruster, 2013/02/22
- [Qemu-stable] [PATCH v2 4/8] vl: Rename *boot_devices to *boot_order, for consistency, Markus Armbruster, 2013/02/22
- [Qemu-stable] [PATCH v2 5/8] pc: Make -no-fd-bootchk stick across boot order changes, Markus Armbruster, 2013/02/22
- [Qemu-stable] [PATCH v2 6/8] pc: Drop ref to Bochs from -no-fd-bootchk documentation, Markus Armbruster, 2013/02/22
- [Qemu-stable] [PATCH v2 7/8] qtest: Don't reset on qtest chardev connect, Markus Armbruster, 2013/02/22
- [Qemu-stable] [PATCH v2 8/8] qtest: Add boot order test, Markus Armbruster, 2013/02/22