[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-stable] [PATCH] esp-pci: fixup deadlock with linux
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-stable] [PATCH] esp-pci: fixup deadlock with linux |
Date: |
Fri, 07 Nov 2014 13:32:10 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 07/11/2014 13:22, Hannes Reinecke wrote:
> A linux guest will be issuing messages:
>
> [ 32.124042] DC390: Deadlock in DataIn_0: DMA aborted unfinished: 000000
> bytes remain!!
> [ 32.126348] DC390: DataIn_0: DMA State: 0
>
> and the HBA will fail to work properly.
> Reason is the emulation is not setting the 'DMA transfer done'
> status correctly.
>
> Signed-off-by: Hannes Reinecke <address@hidden>
Cc: address@hidden
Applied, thanks.
Paolo
> ---
> hw/scsi/esp-pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c
> index 82795e6..77b8647 100644
> --- a/hw/scsi/esp-pci.c
> +++ b/hw/scsi/esp-pci.c
> @@ -268,6 +268,8 @@ static void esp_pci_dma_memory_rw(PCIESPState *pci,
> uint8_t *buf, int len,
> /* update status registers */
> pci->dma_regs[DMA_WBC] -= len;
> pci->dma_regs[DMA_WAC] += len;
> + if (pci->dma_regs[DMA_WBC] == 0)
> + pci->dma_regs[DMA_STAT] |= DMA_STAT_DONE;
> }
>
> static void esp_pci_dma_memory_read(void *opaque, uint8_t *buf, int len)
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-stable] [PATCH] esp-pci: fixup deadlock with linux,
Paolo Bonzini <=