[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 12/31] qemu-img: remove dead check
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 12/31] qemu-img: remove dead check |
Date: |
Tue, 24 Jan 2017 12:39:16 +0300 |
From: Paolo Bonzini <address@hidden>
options must be non-NULL here, because it has been checked before.
Reported by Coverity.
Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
qemu-img.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 5df66fe..74e3362 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -3455,13 +3455,11 @@ static int img_amend(int argc, char **argv)
create_opts = qemu_opts_append(create_opts, bs->drv->create_opts);
opts = qemu_opts_create(create_opts, NULL, 0, &error_abort);
- if (options) {
- qemu_opts_do_parse(opts, options, NULL, &err);
- if (err) {
- error_report_err(err);
- ret = -1;
- goto out;
- }
+ qemu_opts_do_parse(opts, options, NULL, &err);
+ if (err) {
+ error_report_err(err);
+ ret = -1;
+ goto out;
}
/* In case the driver does not call amend_status_cb() */
--
2.1.4
- [Qemu-trivial] [PULL 00/31] Trivial patches for 2017-01-24, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 11/31] pcie: fix typo in comments, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 15/31] qga: fix erroneous argument to strerror, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 12/31] qemu-img: remove dead check,
Michael Tokarev <=
- [Qemu-trivial] [PULL 09/31] object.h: spelling fix, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 01/31] doc: don't mention -memory, it is -m, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 02/31] hw/block/m25p80: Fix typo in local macro name, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 17/31] hw/i386/kvmvapic: Remove dead code in patch_hypercalls(), Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 06/31] hw: Fix typos found by codespell, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 13/31] pci-assign: avoid pointless stat, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 28/31] gdbstub.c: fix GDB connection segfault caused by empty machines, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 31/31] hw/isa/isa-bus: Set category of the "isabus-bridge" device, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 19/31] disas/cris.c: Fix Coverity warning about unchecked NULL, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 25/31] hw/display/framebuffer.c: Avoid overflow for framebuffers > 4GB, Michael Tokarev, 2017/01/24