[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 17/31] hw/i386/kvmvapic: Remove dead code in patch_
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 17/31] hw/i386/kvmvapic: Remove dead code in patch_hypercalls() |
Date: |
Tue, 24 Jan 2017 12:39:21 +0300 |
From: Peter Maydell <address@hidden>
The patch_hypercalls() function sets up a 'patches'
variable and checks it at the end of the function, but
never modifies it in the middle. Remove this dead code,
which seems to have been present since the function was
added in commit e5ad936b0fd7 in 2012.
(Spotted by Coverity: CID 1005581.)
Signed-off-by: Peter Maydell <address@hidden>
Acked-by: Jan Kiszka <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
hw/i386/kvmvapic.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/hw/i386/kvmvapic.c b/hw/i386/kvmvapic.c
index 2f767b6..702e281 100644
--- a/hw/i386/kvmvapic.c
+++ b/hw/i386/kvmvapic.c
@@ -535,7 +535,6 @@ static int patch_hypercalls(VAPICROMState *s)
uint8_t alternates[2];
const uint8_t *pattern;
const uint8_t *patch;
- int patches = 0;
off_t pos;
uint8_t *rom;
@@ -566,11 +565,6 @@ static int patch_hypercalls(VAPICROMState *s)
}
g_free(rom);
-
- if (patches != 0 && patches != 2) {
- return -1;
- }
-
return 0;
}
--
2.1.4
- [Qemu-trivial] [PULL 00/31] Trivial patches for 2017-01-24, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 11/31] pcie: fix typo in comments, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 15/31] qga: fix erroneous argument to strerror, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 12/31] qemu-img: remove dead check, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 09/31] object.h: spelling fix, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 01/31] doc: don't mention -memory, it is -m, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 02/31] hw/block/m25p80: Fix typo in local macro name, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 17/31] hw/i386/kvmvapic: Remove dead code in patch_hypercalls(),
Michael Tokarev <=
- [Qemu-trivial] [PULL 06/31] hw: Fix typos found by codespell, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 13/31] pci-assign: avoid pointless stat, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 28/31] gdbstub.c: fix GDB connection segfault caused by empty machines, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 31/31] hw/isa/isa-bus: Set category of the "isabus-bridge" device, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 19/31] disas/cris.c: Fix Coverity warning about unchecked NULL, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 25/31] hw/display/framebuffer.c: Avoid overflow for framebuffers > 4GB, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 03/31] README: Add linux to macOS build info, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 30/31] usb: Set category and description of the MTP device, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 22/31] util/mmap-alloc: check parameter before using, Michael Tokarev, 2017/01/24
- [Qemu-trivial] [PULL 16/31] doc/usb2: fix typo, Michael Tokarev, 2017/01/24