[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qexo-general] Re: QEXO & XMLForm, 2
From: |
Per Bothner |
Subject: |
Re: [Qexo-general] Re: QEXO & XMLForm, 2 |
Date: |
Fri, 07 Mar 2003 10:01:55 -0800 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3b) Gecko/20030210 |
The patch is completely re-indented, so I still cannot
see the forest for the trees. You could try passing
-b to the diff command:
cvs -n diff -ub files
Note that CallContext.java is a generated file. I need
patches for CallContext.java.in.
The patch to Document.java undoes recent changes of mine,
for example in apply(CallContext) method. Likewise
other places.
You've also changed import statements. If you want to
argue for style changes, keep them separate from substantive
changes.
+ * Document.java: delegates to the current CallContext
+ the responsibility to read a resource
You haven't explained why this is desirable. It doesn't look
like you've considered my recent BaseUri changes, and whether they
can solve the problem.
isLocalResource is wrong, since it doesn't check if there
is a '/' before a ':'. This is a valid relative URL: "foo/a:b".
Use BaseUri.hasScheme instead.
--
--Per Bothner
address@hidden http://www.bothner.com/per/