Re: [Quilt-dev] pushd $SUBDIR for apatch and rpatch?

[Andreas Gruenbacher]

On Monday 09 August 2004 20:43, Joe Green wrote:
> Speaking of $SUBDIR, the attached patch shows some recent changes in CVS
> that look a bit odd.  $SUBDIR is pushd while executing apatch and rpatch
> from push and pop respectively.  What is this supposed to do?

It restores the working directory so that apatch and rpatch will know they 
were invoked from within a sub-directory. (That info would get lost, leading 
to incorrect paths in messages.)

> Most of the code now assumes that it runs in the quilt root, and uses
> $SUBDIR only as needed.  This seems like a nice, clean model.

The apatch.in and rpatch.in scripts should get integrated in the push.in and 
pop.in scripts long-term. I didn't do so yet; this change has enough 
potential to lead to nasty bugs.

Cheers,
-- 
Andreas Gruenbacher <address@hidden>
SUSE Labs, SUSE LINUX AG