Re: [Quilt-dev] [PATCH] give more meaningful error messages

[Raphael Hertzog]

On Mon, 25 Jan 2010, Jean Delvare wrote:
> Le lundi 25 janvier 2010 13:28, Raphael Hertzog a écrit :
> > On Mon, 25 Jan 2010, Jean Delvare wrote:
> > > What is the purpose of this change? What is the user going to do
> > > differently after that?
> > 
> > Lack of series file might meant that the user forgot to point quilt to the
> > right patches dir/series file... so he might retry by setting
> > QUILT_PATCHES correctly this time.
> 
> The user can already do exactly the same today. The error message
> is currently not "QUILT_PATCHES is not set properly", so the user
> already has to translate mentally from "No patches in series" to
> "QUILT_PATCHES is not set properly". Translating from "No series
> file found" instead doesn't seem like a significant improvement
> to me.

It seems an improvement to me. We can't conclude "QUILT_PATCHES is not set
properly" because it's impossible to know whether the user expected a
series file to exist or not, but we can give him that information at
least.

Cheers,
-- 
Raphaël Hertzog