Re: [Quilt-dev] [PATCH] give more meaningful error messages

[Jean Delvare]

Le lundi 25 janvier 2010 11:45, Andreas Gruenbacher a écrit :
> On Monday 25 January 2010 10:36:54 Jean Delvare wrote:
> > What is the purpose of this change? What is the user going to do
> > differently after that?
> 
> The improved message makes things less confusing, no?  I don't see a problem 
> with this change ...

The "problems" I see are: increase in code size, presumably comming
at the price of a small performance hit ("quilt push" seems to be 1%
slower with this change), and possible inconsistencies in error
message wording given the "no preliminary setup required" nature of
quilt. Starting to describe differences which so far were supposed to
be transparent to the user seems strange.

If we are going to apply this change still, then please consider
moving the test to after "if [ -z "$patch" ]", to only slow down the
error path and not the common path. A simple "if [ -e $SERIES ]"
should do if I'm not mistaken. And please also update the test suite
so that it doesn't fail after applying the patch.

Thanks,
-- 
Jean Delvare
Suse L3