quilt-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Quilt-dev] Re: [PATCH] `quilt header -a' corrupts diffstat-carrying hea


From: Don Mullis
Subject: [Quilt-dev] Re: [PATCH] `quilt header -a' corrupts diffstat-carrying headers
Date: Mon, 25 Jan 2010 19:53:28 -0800
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)

Jean Delvare <address@hidden> writes:
> I never use "quilt header -a" myself, and I have to
> admit I am curious what others may be using it for. It doesn't seem
> very useful to me.

What I'd like to use it for is batched appending to a patch series,
e.g. for Linux kernel:

  while quilt top
  do
    echo "Signed-off-by: address@hidden" | quilt header -a
    quilt pop
  done

> The only behavioral change I would consider is the following: if
> a diffstat section is present _and_ it is preceded by "---" _and_ it
> is at the end of the header comment, then "quilt header -a" could be
> made to insert the additional comment right before the "---". But
> even that might go against the expectations of some users.

How about leaving the behavior of -a as it always was, and creating a
'-i' option that would have the functionality you describe?  That way,
there would be no chance of violating existing expectations.  I would be
willing to prepare the patch.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]