[Quilt-dev] Re: [PATCH] `quilt header -a' corrupts diffstat-carrying headers

[Don Mullis]

Jean Delvare <address@hidden> writes:

> Le mardi 26 janvier 2010 04:53, Don Mullis a écrit :

> I'm not a big fan of adding new options for very specific needs. I
> wouldn't even have taken -a in the first place. I think that custom
> header edition needs are better handled by "quilt header" redirected
> to a temporary file, custom edition of that file, and lastly "quilt
> header -r" from that file.
>
> The problem with your "-i" option is that it would insert right before
> the diffstat section (if there is such a section.) But others might
> have other insertion needs, for example at the top of the header (to
> insert a "From:" line), or before the start of the body (to add a
> "Subject:" line), or at the end of the body, or between "---" and the
> diffstat (hidden comment.) And I'm only thinking of the header format
> I use for Linux kernel patches. There must be users out there with
> completely different expectations. I really don't think we want to
> have a new insert option for every possible case.

Thanks for explaining your reasoning, and reminding me of the numerous
cases to be considered.  I agree that "-a" (or "-i") is too specific,
and that any custom automated editing is better done as you describe, by
a script outside of quilt.