[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Quilt-dev] [PATCH] scripts: let users override LESS env variable.
From: |
Martin Quinson |
Subject: |
Re: [Quilt-dev] [PATCH] scripts: let users override LESS env variable. |
Date: |
Mon, 16 Dec 2013 13:44:47 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Dec 16, 2013 at 01:21:51PM +0100, Jean Delvare wrote:
> Le Saturday 14 December 2013 à 13:29 -0600, Kent R. Spillner a écrit :
> > On Sat, Dec 14, 2013 at 02:28:49PM +0100, Jean Delvare wrote:
> > > I do not understand the value of this change. How is it better to set
> > > QUILT_LESS_ARGS in ~/.quiltrc than to set LESS in ~/.quiltrc?
> > >
> > > As far as I can see, the feature was already there, just not documented.
> > > If I'm missing something, please explain.
> >
> > I wouldn't say it is better. I wanted to disable the behavior of less -F
> > but quilt's use of LESS wasn't documented. I chose to add QUILT_LESS_ARGS
> > simply to be consistent with other Quilt env variables, and also to be
> > consistent with other tools that page their output (e.g. MANPAGER,
> > GIT_PAGER,
> > etc.). If you wish to revert my change and simply document LESS I believe
> > that would also suit my needs.
>
> I'd revert it, however Martin said earlier that he loved your change,
> and Andreas was happy enough with it to apply it. So unless Martin
> and/or Andreas changed their mind and tell me I can revert it, I'll just
> leave it as is. I don't want to go against the majority ;-)
Oops, I didn't want to block things here. I found the patch
interesting at the first glance, but your later discussion convinced
me otherwise (yeah, I'm quite easy to convince).
feel free to revert.
Mt
--
I am convinced that this paper does not met the usual quality standard,
but I still recommand its acceptation since I'm marked as a co-author.
Sorry. -- Bastard Professor From Hell