quilt-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Quilt-dev] [patch 4/5] verbosly die if /proc is not mounted


From: Martin Quinson
Subject: Re: [Quilt-dev] [patch 4/5] verbosly die if /proc is not mounted
Date: Sat, 21 Dec 2013 17:33:26 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Tue, Dec 17, 2013 at 03:38:33PM +0100, Jean Delvare wrote:
> Hi Martin,
> 
> Le Wednesday 19 December 2012 à 15:35 +0100, address@hidden a
> écrit :
> > --- a/bin/patch-wrapper.in
> > +++ b/bin/patch-wrapper.in
> > @@ -171,6 +171,10 @@ then
> >      if [ -n "$opt_input" ]
> >      then
> >     patch=$opt_input
> > +    elif [ ! -e /proc/self ]
> > +    then
> > +        echo "patch-wrapper: /proc not mounted!" >&2
> > +   exit 1
> >      elif [ -e /proc/self/fd/0 ]
> >      then
> >     patch=$(readlink /proc/self/fd/0)
> 
> I have no idea what patch-wrapper is good for, I don't use it. So I
> can't have any objection or useful comment about the change above. Feel
> free to commit it if you need that change. Please just fix the
> indentation before you do so ;-)

Done. (it's very helpful to detect that your chroot does not have
/proc mounted).

One patch less in debian \o/ 

Bye, Mt.

-- 
Oh, I am a C programmer and I'm okay. 
I muck with indices and structs all day. 
And when it works, I shout hoo-ray. 
Oh, I am a C programmer and I'm okay.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]