Re: [RP] [PATCH 3/6] Disable sfdump if there is no xrandr support.

[Jeremie Courreges-Anglas]

Mathieu OTHACEHE <address@hidden> writes:

>> No idea whether how stable would be the mapping between Xrandr ids and
>> ratpoison ids, though, as we don't control the former.  There's not much
>> choice though, but 1. you already have implemented a screen_sort
>> function, and 2. this sounds better than forcing the user to deal with
>> numbers like 42 and 66, especially for 'sselect'. :)
>
> I could use numset (fron number.c), to affect an id to each screen.
> The id would be affected at ratpoison start, once screen are detected
> and sorted.

This makes me think that screens are currently sorted with only a
"left < right" criteria, maybe total ordering with an additional
"top < bottom" could be interesting.

(Which makes me think that screen_sort() happens early, thus we
should probably check that we do respect Xrandr's rotations even when
they happen early / before ratpoison even exists...)

>
> Then, if a screen is removed, its numset is released. On screen plugging, a
> new numset is affected.

My lack of knowledge about multiple-screens setups strikes again: do you
mean to say that just unplugging a screen makes Xrandr notify ratpoison
that the screen went away?  I thought that some kind of manual (or
preconfigured) intervention with xrandr(1) or any other GUI tool was
needed.  If not, I'd say that

> On the positive side, if the user doesn't add or remove screens, its
> screen will keep using the same ids.
>
> On the negative side, if the user unplug a screen and plug a different
> screen, it will have the same id as the previously unplugged screen.

Well, if screen A in unplugged from "slot 1" and screen B is then
plugged in "slot 1", then I think this is the desired behavior.  BTW, do
the Xrandr IDs change when you do that?

> What's your opinion about it ?

Sounds good at first, I think providing a stable ordering for static
setups is enough to make current users happy.  I'm wondering how much
people are relying on sselect.

> Thanks,

Thank *you* in advance for bearing with me.  I'm really a "one laptop
screen will do" kind of guy.  This Xrandr thingie almost makes me want
to buy extra screens just so that I can stop looking stupid. :)

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

signature.asc
Description: PGP signature