Re: [Savannah-register-public] [task #13713] Submission of Gnu Slip

[Arthur Schwarz]

Hi Assaf;

Comments are interspersed with statements below.

The new, improved and never seen before tarball is included. 

Now my question. I am sending you a tarball in order for you to continue
validation. Who is responsible to getting this tarball into Savannah? (And
if me, how do I do it. I know, I know, just read the manual - but there's so
much manual.)

thanks
art


-----Original Message-----
>  From: Assaf Gordon [mailto:address@hidden
>  Sent: Tuesday, August 11, 2015 4:12 PM
>  To: Assaf Gordon; Art Schwarz; address@hidden
>  Subject: [task #13713] Submission of Gnu Slip
>  
>  Update of task #13713 (project administration):
>  
>                    Status:                    None => Wait reply

>               Assigned to:                    None => agn

>  
>      _______________________________________________________
>  
>  Follow-up Comment #1:
>  
>  Hello Arthur,
>  
>  Thank you submitting a new GNU project.
>  
>  Before creating the project, I do have one suggestion:
>  The name "slip" is already used by several other technical terms (e.g.
Serial-Line-IP).
>  Since your project is a library, and the main output is 'libslip.a',
would you be open to calling the project 'libslip' ?
>  That would hopefully prevent future confusion.

As agreed, the name is gSlip, short for Gnu Slip.

>  
>  ---
>  
>  Additionally,
>  below are few optional items relevant to project hosted on Savannah:
>  
>  1. Few files don't have any copyright or license statements:
>     src/Makefile.am
>     src/TestUtilities.cc
>     src/slip.lex
>     src/slip.y
>  Please consider adding a copyright statement and license notice to these
files.

All files have been modified.

>  
>  
>  2. Several files give copyright assignment to "Free Software Foundation"
>  (e.g. README, NEWS), but the rest of the files are "Copyright (C) 2014
Arthur I. Schwarz".

  grep -i copyright AUTHORS ChangeLog config.h configure.ac configure.scan
install NEWS  PACKAGING README THANKS TODO

Yields:
config.h:/* The copyright year for this package */
  config.h:#define PACKAGE_COPYRIGHT_YEAR 2015
  configure.ac:AC_COPYRIGHT([GPL])
  configure.ac:AC_SUBST([PACKAGE_COPYRIGHT_YEAR], [2015])
  configure.ac:AC_DEFINE_UNQUOTED([PACKAGE_COPYRIGHT_YEAR],
[$PACKAGE_COPYRIGHT_YEAR],
  configure.ac:                   [The copyright year for this package])auto
  install:Copyright (C) 1994-1996, 1999-2002, 2004-2013 Free Software
Foundation,
  install:are permitted in any medium without royalty provided the copyright
  NEWS:Copyright (C) 2014-2015 Free Software Foundation, Inc.
  NEWS:are permitted in any medium without royalty provided the copyright
  README:Copyright (C) 2014 Free Software Foundation

  grep -i schwarz config* Makefile* NEWS AUTHORS install README TODO
ChangeLog config.log
  
Yields: NIL

The tarball you have is somehow wrong. The new tarball has everything
(hopefully) correct.

>  
>  A GNU Package does not automatically assigns copyright to the FSF.
>  The GNU Maintainer's guide explains:
>  "GNU packages need not be FSF-copyrighted; this is up to the author(s),
generally at the time the package is dubbed GNU. When copyright is assigned
to the FSF, the FSF can act to stop GPL violations about the package.
>  Otherwise, legal actions are up to the author(s)."
>  (from
>
https://www.gnu.org/prep/maintain/html_node/Copyright-Papers.html#Copyright-
Papers).
>  
>  If you do want to re-assign copyright, then you'll need to contact the
FSF and explicitly assign it.
>  And then - *all* source code must be "copyright (C) free software
foundation", instead of "Arthur I. Scharz".
>  
>  If you choose not to assign copyright to FSF, please update the
README/NEWS (and any other file you've created) to list you as the copyright
owner.
>  
>  3. There is a large user-manual in PDF format, but without the source
code (needed to re-generate this PDF).
>  It is recommended to provide a source code in texinfo format, see here:
https://www.gnu.org/prep/standards/html_node/GNU-Manuals.html

I have an OpenOffice (.odt) document. I am working on a Texinfo document but
am having some difficulty. I will include the .odt file, and since
OpenOffice is OpenSource, this should (temporarily) solve some of your
concerns. Please advise me if this is not the Correct Solution, but note
that at the present time there is no Texinfo document available.

>  
>  
>  And few minor recommendations:
>  
>  4. seems like there's a superfluous 'auto' in line 28 of 'configure.ac'.

Thank you. Hopefully I have removed any superfluidities.

>  
>  5. The code in its current form doesn't compile for me, file
'src/SlipInputMethods.cc' includes a non-existing file 'lex.slip.h' - there
is a file named 'lex.Slip.h' (with a capital 'S') - perhaps that's a typo.
>  It's probably best to avoid files with mixed-case for portability.

Thank you for pointing this out. I am running on a Win7 machine using
Cygwin. I keep stumbling on the capitilization, and I thank you for pointing
it out.

>  
>  6. The unit-test program is called 'test' (in Makefile.am) - on unix
systems there is a common program called 'test' (and usually also a shell
builtin called 'test') - this might cause some issues.
>  it's probably safer to rename it for portability.

I have changed it (and the file it came from) to SlipTest (and SlipTest.cc).
I trust your judgment on this, but if the test is executed in the file
containing test.exe then the /usr/bin/test file is not executed and there
should have been no conflict. Even with /usr/bin/test having the same name
(test) I can't see why a user would want to execute '> test' instead of '>
path/../test'. But, the change was easy and now it's done.

>  
>  regards,
>   - assaf
>   
>  
>      _______________________________________________________
>  
>  Reply to this item at:
>  
>    <http://savannah.gnu.org/task/?13713>
>  
>  _______________________________________________
>    Message sent via/by Savannah
>    http://savannah.gnu.org/
>

Slip-1.0.tar.xz
Description: Binary data