sks-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Sks-devel] Screen corruption on current CVS (op=index)


From: Olaf Gellert
Subject: Re: [Sks-devel] Screen corruption on current CVS (op=index)
Date: Tue, 24 Feb 2004 12:48:38 +0100

Pramberger Peter wrote:
Yaron M. Minsky schrieb:

I'm coming in a bit late to this discussion.  One thing I'm not sure
about: is there any reason to think that there is a bug in SKS here? Do we think SKS caused the corruption?


The corruption on the index page? I think yes. Some thing must have changed in the parsing code between 1.6 and the current CVS.

As far as I understand the code in index.ml after the decision to create a link or not the data is passed to html_quote. The binary data is correctly quoted, as I can see on the page source code. So one possibility (in my opinion) is that the "binary image uid" was already filtered out in 1.6 before reaching this point.

Would it be possible/difficult to implement a query to sks that returns the
photo-ID (as an image)? Then one could include a link to this query
in the output for this key (so the image would be displayed if you
are using a webbrowser to search the keys). Or would that break the
parsing of this output from all the other pgp-applications (gpg etc)?
Yes, I know, this is just a funny feature, but what are the photo-
ids for if they are not displayed?

As for filtering it out, we could put a limit on userid packet length. And we could put a filter on characters, though that might kill some
useful foreign-language strings if not done well.  If someone has a
proposal (ideally with some code to match) I'd be happy to merge it in.
Hm? The photo-id-packet should be clearly marked as being a photo-ID,
or am I wrong? So we do not need to limit the userid packet length
(why should we implement restrictions on some packages that are not required
by the standard). Or do I simply not understand your question? ;-)

Cheers, Olaf

--
Dipl.Inform. Olaf Gellert                  PRESECURE (R)
Consultant,                              Consulting GmbH
Phone: (+49) 0700 / PRESECURE           address@hidden





reply via email to

[Prev in Thread] Current Thread [Next in Thread]