Re: [Sks-devel] Screen corruption on current CVS (op=index)

[Pramberger Peter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Yaron M. Minsky schrieb:
> I'm coming in a bit late to this discussion.  One thing I'm not sure
> about:  is there any reason to think that there is a bug in SKS here? 
> Do we think SKS caused the corruption?

The corruption on the index page? I think yes. Some thing must have 
changed in the parsing code between 1.6 and the current CVS.

As far as I understand the code in index.ml after the decision to create 
a link or not the data is passed to html_quote. The binary data is 
correctly quoted, as I can see on the page source code. So one 
possibility (in my opinion) is that the "binary image uid" was already 
filtered out in 1.6 before reaching this point.

> As for filtering it out, we could put a limit on userid packet length. 
> And we could put a filter on characters, though that might kill some
> useful foreign-language strings if not done well.  If someone has a
> proposal (ideally with some code to match) I'd be happy to merge it in.

I think of some filtering on the UID and replace it by some text (as in 
gnupg), but I have no idea how to do this in Ocaml:

    if (uid_string.[(x+)0] = 0xFF && uid_string.[(x+)1] = 0xD8 &&
        uid_string.[(x+)6] = 'J'  && uid_string.[(x+)7] = 'F'  &&
        uid_string.[(x+)8] = 'I'  && uid_string.[(x+)9] = 'F')
       then "[jpeg image]"


Peter

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFAOzXZomkGBEVXBcMRAuopAKC9YT3AwOZWhSIovqqgASsWv5ld0ACeJk7y
LNpT0Lvraxexw2y+et6uczw=
=F52u
-----END PGP SIGNATURE-----