Re: [Straw-devel] Image Bug

[Juri Pakaste]

On Tue, 2003-10-28 at 15:16, Jan Alonzo wrote:
> On Tue, 2003-10-28 at 23:55, Scott Douglas-Watson wrote:
> > Here's the problem feed -
> > http://blogs.gotdotnet.com/BradA/blogxbrowsing.asmx/GetRss?
> > 
> > The problem is the URL fetcher only uses protocol http:// and in the
> > feed the person references a local file in the image tag, protocol file://
> 
> Thanks. We can either remove the assertion or add 'file://' as a special
> case(pretend it's ok). 

Ah, serves me right for not following the list closely enough. I was
wondering about the commit. I disagree with this change, the assertion
was there for a good reason and what should be done is we should catch
the exception in an appropriate place (well, probably we should create a
real exception class for the check) and display the error as usual (in
the case of images, as a broken image icon.) What't the point in letting
a file:/// URL through as we can't do anything sane about it anyway?

-- 
[ Juri Pakaste / address@hidden / http://www.iki.fi/juri/ ]