stumpwm-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [STUMP] [PATCH] Enhancements to the interactive module loading.


From: Shawn Betts
Subject: Re: [STUMP] [PATCH] Enhancements to the interactive module loading.
Date: Mon, 13 Jul 2009 01:07:14 -0700
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux)

David Vazquez <address@hidden> writes:

> The `load-module' command fails in sbcl when it is invoked
> interactively. I fixed this.
>
> I also remove the tailing space which is introduced by `read-one-line'
> in order to load-module found it. Indeed, I add a new argument
> REQUIRE-MATCH to `completing-read' to make sure that the input module
> exists.

Thanks for the heads up about load-module. I fixed it and also made
completing-read trim spaces off the ends of the string.

A REQUIRE-MATCH field would be great for completing-read but I don't
think your implementation is quite good enough. It'd be nice if it
behaved more like emacs where it displays the "no match" text beside
the input and doesn't force you to wait half a second if you hit a
key. A (sleep-until-keypress 0.5) function would be perfect here.

If you're up for implementing that, I'd commit it.

-Shawn




reply via email to

[Prev in Thread] Current Thread [Next in Thread]