stumpwm-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [STUMP] [PATCH] Enhancements to the interactive module loading.


From: David Vazquez
Subject: Re: [STUMP] [PATCH] Enhancements to the interactive module loading.
Date: Wed, 15 Jul 2009 05:55:21 +0200
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux)

Shawn Betts <address@hidden> writes:

> Thanks for the heads up about load-module. I fixed it and also made
> completing-read trim spaces off the ends of the string.
>
> A REQUIRE-MATCH field would be great for completing-read but I don't
> think your implementation is quite good enough. It'd be nice if it
> behaved more like emacs where it displays the "no match" text beside
> the input and doesn't force you to wait half a second if you hit a
> key. A (sleep-until-keypress 0.5) function would be perfect here.
>
> If you're up for implementing that, I'd commit it.

Of course, I attach you a new patch. Now, The [No match] text is
displayed until the following key is pressed. Time limit could be
added. It also fix a bug in the completing-read function, which return
"NIL" as string if the user aborted (SBCL 1.0.18.debian). Finally, I
changed module.lisp to use the require-match argument.

I hope it is correct, but let me know something you dislike in order
to I fix it.

Greetings,
David.

Attachment: 0001-Add-optional-argument-REQUIRE-MATCH-to-the-completin.patch
Description: Patch


reply via email to

[Prev in Thread] Current Thread [Next in Thread]