Re: RE : [Tsp-devel] Source indentation

[Frederik Deweerdt]

On Thu, Apr 26, 2007 at 08:14:57PM +0200, Eric Noulard wrote:
> >> (2) is a bad technical choice since it is Windows specific
> >>     We should use a separate .def file as the one used by ACPLT-ONCRPC
> >>     but I didn't realize It was possible at the time we did TSP Win32 port 
> >> :))
> >:), I'll try to do this but I don't think it is a must before applying
> >indent.
> 
> Yes I agree, it is not a top-one priority just a thought
> may be a task to create in the tracker in order to keep it in mind.
OK, done

I've done various tests on .o generated files before and after indent.
After:
- compiling in Release mode
- replacing STRACE_ERROR, STRACE_WARN macros with empty defines
I've copied all generated .o files in /tmp/indent and /tmp/vanilla
respectively.
The result is:
$ diff -pruN /tmp/{indent,vanilla}/
Binary files /tmp/indent/gtkdatabox.o and /tmp/vanilla/gtkdatabox.o differ
Binary files /tmp/indent/plotwindow.o and /tmp/vanilla/plotwindow.o differ
After examining the generated code, this is due to the
g_return_val_if_fail macro which takes the line number, the generated
code thus differs.
So, IMO, find . -name '*.[ch]' -exec indent -i8 -kr -l200 {} \; 
is safe. I'll do it at the end of the week unless some one spots a
problem I missed.

Regards,
Frederik