[avr-libc-dev] [bugs #11505] inp()/outp() comments in ./include/avr/sfr_defs.h outdated

[Eric Weddington]

This mail is an automated notification from the bugs tracker
 of the project: AVR C Runtime Library.

/**************************************************************************/
[bugs #11505] Latest Modifications:

Changes by: 
                Eric Weddington <address@hidden>
'Date: 
                Fri 01/07/2005 at 19:26 (America/Denver)

            What     | Removed                   | Added
---------------------------------------------------------------------------
    Percent Complete | 80%                       | None
              Status | Open                      | Closed


------------------ Additional Follow-up Comments ----------------------------
[(Error - Not Found)]
Fixed on 1.2 branch. Bug closed.






/**************************************************************************/
[bugs #11505] Full Item Snapshot:

URL: <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=11505>
Project: AVR C Runtime Library
Submitted by: Mudiaga Obada
On: Wed 01/05/2005 at 21:41

Category:  Documentation
Severity:  5 - Average
Priority:  5 - Normal
Item Group:  None
Resolution:  None
Privacy:  Public
Percent Complete:  None
Assigned to:  arcanum
Originator Email:  address@hidden
Status:  Closed


Summary:  inp()/outp() comments in ./include/avr/sfr_defs.h outdated

Original Submission:  It seems like the documentation in 
./include/avr/sfr_defs.h was left in there after inX()/outX() support was 
removed.

The following should be removed:

<quote>
   The old inp()/outp() macros are still supported, but not recommended to use
   in new code.  The order of outp() arguments is confusing. </quote>

Also the lines

#if _SFR_IO_REG_P(SPMCR)
        out     _SFR_IO_ADDR(SPMCR), r24
#else
        sts     _SFR_MEM_ADDR(SPMCR), r24
#endif

look stray, since i can't tell from their (stand alone) context what they are 
there for. Also, the comments that follow it looks strage to me...

For my oppinion (which i know comes rather late), no longer having inX()/outX() 
and cbi()/sbi() support is unfortunate. There's lot of existing code that uses 
it, and it can be really inconvinient - especially for those new to 
gcc/avr-libc.



Follow-up Comments
------------------


-------------------------------------------------------
Date: Fri 01/07/2005 at 19:26       By: Eric Weddington <arcanum>
Fixed on 1.2 branch. Bug closed.

-------------------------------------------------------
Date: Fri 01/07/2005 at 19:04       By: Eric Weddington <arcanum>
Fixed on HEAD. Will fix on 1.2 branch....

-------------------------------------------------------
Date: Wed 01/05/2005 at 21:54       By: Mudiaga Obada <obada>
Ok, i see what 

#if _SFR_IO_REG_P(SPMCR)
out _SFR_IO_ADDR(SPMCR), r24
#else
sts _SFR_MEM_ADDR(SPMCR), r24
#endif

has to do with __SFR_OFFSET. Please ignore that part of the previous message.













For detailed info, follow this link:
<http://savannah.nongnu.org/bugs/?func=detailitem&item_id=11505>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/