[Bug gold/22868] Gold does not select proper symbol visibility when used with LLVM gold-plugin

[georgerim at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=22868

--- Comment #6 from georgerim at gmail dot com ---
(In reply to Cary Coutant from comment #5)
> I'm not able to reproduce this problem in my test framework. Whether or not
> we override the symbol when scanning the IR, we still pick up the visibility
> when processing the replacement files.
> 
> Could it be the case that your replacement objects do not have the
> STV_PROTECTED visibility on the symbol?

Not sure what do you mean by "replacement object"?
But in my case (1st post), the order of objects in the command line
affected the visibility.

I also tested the attachment from Bug 22994 today and issue reproduced for me
with
the latest gold sources:

~/binutils-2.30-branch/binutils-gdb/build/gold/ld-new -v
GNU gold (GNU Binutils 2.30.51.20180323) 1.15

~/binutils-2.30-branch/binutils-gdb/build/gold/ld-new -shared -o c.o -plugin
/home/umb/LLVM/build_goldplugin/lib/LLVMgold.so a.o b.o -m elf_x86_64
-plugin-opt=save-temps
readelf --syms c.o | grep f1
    18: 00000000000005b0     6 FUNC    WEAK   DEFAULT    8 f1
     2: 00000000000005c0     2 FUNC    LOCAL  DEFAULT    8 f1.2
    24: 00000000000005b0     6 FUNC    WEAK   DEFAULT    8 f1

~/binutils-2.30-branch/binutils-gdb/build/gold/ld-new -shared -o c.o -plugin
/home/umb/LLVM/build_goldplugin/lib/LLVMgold.so b.o a.o -m elf_x86_64
-plugin-opt=save-temps
readelf --syms c.o | grep f1
    10: 0000000000000490     2 FUNC    WEAK   PROTECTED    6 f1
    17: 0000000000000490     2 FUNC    WEAK   PROTECTED    6 f1

-- 
You are receiving this mail because:
You are on the CC list for the bug.