[Bug gold/22868] Gold does not select proper symbol visibility when used with LLVM gold-plugin

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=22868

--- Comment #13 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot 
gnu.org> ---
The binutils-2_30-branch branch has been updated by Cary Coutant
<address@hidden>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=330b90b5ffbbc20c5de6ae6c7f60c40fab2e7a4f

commit 330b90b5ffbbc20c5de6ae6c7f60c40fab2e7a4f
Author: Cary Coutant <address@hidden>
Date:   Fri Mar 23 09:03:34 2018 -0700

    Fix case where IR file provides symbol visibility but replacement file does
not.

    In PR 22868, two IR files provide conflicting visibility for a symbol.
    When a def with PROTECTED visibility is seen after a def with DEFAULT
    visibility, gold does not override the visibility. Later, if the
    replacement object define the symbol with DEFAULT visibility, the symbol
    remains DEFAULT. This was caused by a recent change to allow
multiply-defined
    absolute symbols, combined with the fact that the plugin framework was
using
    SHN_ABS as the section index for placeholder symbols. The solution is to
    use a real (but arbitrary) section index.

    gold/
        PR gold/22868
        * plugin.cc (Sized_pluginobj::do_add_symbols): Use a real section
        index instead of SHN_ABS for defined symbols.
        * testsuite/Makefile.am (plugin_pr22868): New test case.
        * testsuite/Makefile.in: Regenerate
        * testsuite/plugin_pr22868.sh: New test script.
        * testsuite/plugin_pr22868_a.c: New source file.
        * testsuite/plugin_pr22868_b.c: New source file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.