[Bug binutils/31527] gdb is not working for UNC path

[nickc at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=31527

--- Comment #13 from Nick Clifton <nickc at redhat dot com> ---
(In reply to Simon Cook from comment #12)
Hi Simon,

> Patch with my suggested change, and done some testing pre-the previous fix
> and with my change and verified UNC paths still work. (Tested using ld
> loading static archives which was the case of this I found, I'm happy to do
> any before/after validation on GDB if someone has some steps to reproduce
> the original issue)

+  bool is_network_path = strncmp (filename, "//", 2) == 0
+                        || strncmp (filename, "\\\\", 2) == 0;

Won't this test falsely match DOS paths that start with: \\?\, 
eg \\?\D:foo\bar  

IE shouldn't the test be:

  bool is_network_path = strncmp (filename, "//", 2) == 0
                         || strncmp (filename, "\\\\?\\UNC\\", 8) == 0;

Also, since we have a startswith() function the check could be simplified to:

 bool is_network_path = startswith (filename, "//")
                 || startswith (filename, "\\\\?\\UNC\\");


> Submitting here since that's where the original patch was, but if you'd
> rather me send it to the list, I'm happy doing that also.

Either place is good...

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.