RE: Win32 - src/serial.cpp Visual C++ 6.0 Build Error

[Conrad T. Pino]

Hi David,

> From: David Sugar
> 
> I believe this issue exists not just for serial, but some other 
> exception classes which define String rather than const String & as 
> their constructor, since all are inhereted through Exception, which 
> expects const String &.

Yes that is true.  While getting the project to compile I didn't check
all Exception descendants.  My check was limited to comparing "serial.h"
to "exception.h" files.  My grep confirming your belief is confirmed
below:

Since SourceForge lists you as 1 of 2 project managers I was wondering
if you could provide feedback if "serial.cpp" patch will be committed.

My thoughts on Exception class constructors is "const String &" is
preferable to "String" but that is secondary to consistent usage IMO.

I'm willing to provide more patches if there's interest in having them
committed in a timely fashion.

Best regards,

Conrad Pino

File include\cc++\digest.h:
257             DigestException(String str) : Exception(str) {};

File include\cc++\exception.h:
83              Exception(const String& what_arg) throw();
102             IOException(const String &what_arg, long systemError = 0) 
throw();
118             ThrException(const String &what_arg) : Exception(what_arg) 
131             SyncException(const String &what_arg) : 

File include\cc++\file.h:
960             DirException(String str) : IOException(str) {};
966             DSOException(String str) : IOException(str) {};
972             FIFOException(String str) : IOException(str) {};
978             PipeException(String str) : IOException(str) {};
984             FileException(String str) : IOException(str) {};

File include\cc++\persist.h:
83              PersistException(String what) : Exception(what) {};
91              CCXX_MEMBER_EXPORT(CCXX_EMPTY) PersistException(const String& 
reason);
254                     CCXX_MEMBER_EXPORT(CCXX_EMPTY) Exception(const String 
&reason);

File include\cc++\serial.h:
879             SerException(const String &str) : IOException(str) {};

File include\cc++\socket.h:
2309            SockException(String str, Socket::Error socketError, long 
systemError = 0) :