Re: Broken CVS tree?

[Jerzy Kaczorowski]

Hi,

I added one include file (patch down below).

--------------------Configuration: cvsnt - Win32 Debug--------------------
Compiling...
buffer.c
D:\ccvs\ccvs\src\buffer.c(1407) : warning C4013: 'S_ISSOCK' undefined;
assuming extern returning int
Linking...
buffer.obj : error LNK2001: unresolved external symbol _S_ISSOCK
.\Debug\cvs.exe : fatal error LNK1120: 1 unresolved externals
Error executing link.exe.

cvs.exe - 2 error(s), 1 warning(s)

So now only the S_ISSOCK is the problem, I added winsock.h to the includes,
here is the patch:

CvsIn: C:\Program Files\GNU\WinCvs 1.2\cvs.exe -r -z8  diff buffer.c  (in
directory "D:\ccvs\ccvs\src") [2001/06/21 08:25:58]
Index: buffer.c
===================================================================
RCS file: /cvsroot/ccvs/src/buffer.c,v
retrieving revision 1.16
diff -u -r1.16 buffer.c
--- buffer.c 20 Jun 2001 18:40:49 -0000 1.16
+++ buffer.c 21 Jun 2001 00:22:33 -0000
@@ -4,6 +4,8 @@
 #include "cvs.h"
 #include "buffer.h"

+#include <winsock.h>
+
 #if defined (SERVER_SUPPORT) || defined (CLIENT_SUPPORT)

 /* OS/2 doesn't have EIO.  FIXME: this whole notion of turning

***** CVS exited with code 1 [2001/06/21 08:26:00] *****

Best Regards,
Jerzy


----- Original Message -----
From: "Derek R. Price" <dprice@collab.net>
To: "Jerzy Kaczorowski" <jerzyk@wndtabs.com>
Cc: "Larry Jones" <larry.jones@sdrc.com>; <bug-cvs@gnu.org>
Sent: Thursday, June 21, 2001 4:00 AM
Subject: Re: Broken CVS tree?


> Jerzy Kaczorowski wrote:
>
> > OK, it is better, but still cant pass the linking - here is what I am
> > getting now:
> >
> > --------------------Configuration: cvsnt - Win32
Debug--------------------
> > Linking...
> > buffer.obj : error LNK2001: unresolved external symbol _shutdown
> > buffer.obj : error LNK2001: unresolved external symbol _S_ISSOCK
> > client.obj : error LNK2001: unresolved external symbol _S_ISSOCK
> > .\Debug\cvs.exe : fatal error LNK1120: 2 unresolved externals
> > Error executing link.exe.
> >
> > cvs.exe - 4 error(s), 0 warning(s)
> >
> > I also removed the #define NO_SOCKET_TO_FD 1
> > from the ccvs\windows-NT\config.h (could not find system.h) but with
>
> My fault.  That's what I meant.
>
>
> > similiar
> > errors:
> >
> > --------------------Configuration: cvsnt - Win32
Debug--------------------
> > Linking...
> > buffer.obj : error LNK2001: unresolved external symbol _shutdown
> > buffer.obj : error LNK2001: unresolved external symbol _S_ISSOCK
> > .\Debug\cvs.exe : fatal error LNK1120: 2 unresolved externals
> > Error executing link.exe.
> >
> > cvs.exe - 3 error(s), 0 warning(s)
>
> Okay, I'm not going to have any more time to work on this today, so I'll
tell
> you what I know before I go:
>
> This baffles me since S_ISSOCK is supposed to be a POSIX macro and
shutdown is
> also called from window-NT/startserver.c, which hasn't had any changes
made to
> it since 1998 and which I know was compiling withing the last year.
>
> Anyway if you can find any difference between the compilation commands for
> startserver.c and buffer.c in the makefile (toplevel, ./cvsnt.mak), then
that
> might be a good place to start.
>
> lib/system.h defines S_ISSOCK sometimes.  Getting it to be defined for
your
> build might be usable as a last resort.  I would think though, if the
Windows
> compiler didn't complain about S_ISSOCK until the link stage that Windows
was
> defining it somewhere and something else is wrong though.
>
> Derek
>
> --
> Derek Price                      CVS Solutions Architect (
http://CVSHome.org )
> mailto:dprice@collab.net         CollabNet ( http://collab.net )
> --
> Of all the gin joints in all the towns in all the world, she walks into
mine.
>
>                 - Humphrey Bogart as Rick, _Casablanca_
>
>
>
>