S_IFSOCK truble (was Broken CVS tree?)

[Jerzy Kaczorowski]

After adding the winsock.h include (see my previous mail), which solves the
missing "shutdown" error, the trouble with S_IFSOCK exhibits in the
following way:

1. With the config.h containing #define NO_SOCKET_TO_FD 1
<snip...>
D:\ccvs\ccvs\src\buffer.c(1407) : warning C4013: 'S_ISSOCK' undefined;
assuming extern returning int
<snip>
D:\ccvs\ccvs\src\client.c(3776) : warning C4013: 'S_ISSOCK' undefined;
assuming extern returning int
<snip...>
Linking...
buffer.obj : error LNK2001: unresolved external symbol _S_ISSOCK
client.obj : error LNK2001: unresolved external symbol _S_ISSOCK
.\Debug\cvs.exe : fatal error LNK1120: 1 unresolved externals
Error executing link.exe.
cvs.exe - 3 error(s), 221 warning(s)

2. Without the NO_SOCKET_TO_FD defined:
<snip>
D:\ccvs\ccvs\src\buffer.c(1407) : warning C4013: 'S_ISSOCK' undefined;
assuming extern returning int
<snip>
Linking...
buffer.obj : error LNK2001: unresolved external symbol _S_ISSOCK
.\Debug\cvs.exe : fatal error LNK1120: 1 unresolved externals
Error executing link.exe.
cvs.exe - 2 error(s), 218 warning(s)

In the client.c the code using the S_IFSOCK is protected by #ifdef
NO_SOCKET_TO_FD, but in the buffer.c it's not.

The solution would then be to either:
1. \ccvs\windows-NT\config.h remove the NO_SOCKET_TO_FD define.
2. Guard the code using S_IFSOCK in the buffer.c
or
3. define S_IFSOCK somewhere so both files can compile.
S_IFSOCK is not defined on VC++ platform, and there is no mention about it
in the whole MSDN (I was hoping for a while that installing platform SDK
would solve the problem, but now I doubt it will...)

Cheers,
Jerzy