Re: patch: trailing slash messes up export

[Derek Robert Price]

miles zarathustra wrote:

> > Larry meant to say, "Thanks!  Keep sending patches!"  :)
> >
> >    
>
> Good to see you're so responsive (other open-source projects are not,
> always) ... I haven't had any other need to patch cvs, so it must be
> perfect, other than the one little thing.  ;->
>
> Sounds like you've got it much better under control than I do.  Thanks for
> the good work, and the great application.

Can you send a few commands duplicating the problem that caused you to 
report this in the first place?  Removing the "/"s from CVSROOTs 
shouldn't hurt, but I tried your export command as described with 1.12.1 
and had no problems.

> [root.c]
>  
>
> * NOTES
> *      This would have been a lot easier to write in Perl.
> <<
>
> LOL!
>  

Heh, well:

   ($dummy, $method, $dummy, $username, $dummy, $password, $dummy, 
$hostname, $dummy, $port, $directory) =
       $cvsroot =~ 
m{^(:([a-z]+):)?(([A-Za-z0-9_]+)(:([^\@]*))?\@)?(([A-Za-z0-9_-]*)(:([0-9]+))?)?(/.+)$};

Is a lot shorter that the parse_cvsroot function, even if it isn't less 
cryptic.  I suppose I might have been able to do something similar with 
the C regexp library, but it almost certainly still would have taken 
more lines & characters.  :)

Derek

--
               *8^)

Email: derek@ximbiot.com

Get CVS support at <http://ximbiot.com>!
--
This score just in: OS/2, Windows 95, LinuxPPC 2000.