|
From: | Damien Cassou |
Subject: | bug#36052: 26.2.50; [PATCH] Improve auth-source-pass |
Date: | Sat, 08 Jun 2019 17:47:53 +0200 |
Hi Noam and everyone, thank you *very* much for your review. I appreciate the effort to review such a series of patches. Please find attached the new patches. I took all your comments into account except for what follows: Noam Postavsky <npostavs@gmail.com> writes: > Damien Cassou <damien@cassou.me> writes: >> * lisp/auth-source-pass.el: Private functions were refactored to >> reduce the number of decryption operations. > > Double spacing, and this ChangeLog entry is a little sparse. It looks > like the last two prose paragraphs could be easily made into ChangeLog > entries, since they're already talking about specific functions. I thought about doing that as well but didn't. If you insist, I will do the requested changes but here are my reasons for not doing it right away: - The changes are on private methods (with the "--" naming convention) and I'm not sure how much of private changes should be in the ChangeLog. - The commit message you mention modifies functions that are modified again by a later patch (named "Refactoring of auth-source-pass"). I usually only send the latest version of my code and not the whole history but, this time, I'm not the author of the original version and I believe the author deserves to have his name in Emacs' git history because of the massive work he did for the package. - I have tried not to rewrite too much of contributor's code and text in their own commit so that the authorship makes sense. I have no problem changing contributions in a later commit though (as I've shown in the patch "Refactoring of auth-source-pass"). What do you think? >> * lisp/auth-source-pass.el: Refactoring. > > This one's a little empty too. Changes are again on private functions. What do you suggest? Thank you again for your work! -- Damien Cassou http://damiencassou.seasidehosting.st "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill
0001-Fix-auth-source-pass-to-return-nil-if-no-entry-found.patch
Description: Text Data
0002-lisp-auth-source-pass.el-Version-4.0.2.patch
Description: Text Data
0003-lisp-auth-source-pass.el-auth-source-pass-get-Add-au.patch
Description: Text Data
0004-Add-auth-source-pass-filename-option.patch
Description: Text Data
0004-Add-auth-source-pass-path-option.patch
Description: Text Data
0005-Add-auth-source-pass-port-separator-option.patch
Description: Text Data
0006-Fix-auth-source-pass-to-search-for-hostname-port-use.patch
Description: Text Data
0007-Split-out-the-attribute-retrieval-form-auth-source-p.patch
Description: Text Data
0008-Minimize-entry-parsing-in-auth-source-pass.patch
Description: Text Data
0009-lisp-auth-source-pass.el-Add-Keith-Amidon-to-authors.patch
Description: Text Data
0010-Refactoring-of-auth-source-pass.patch
Description: Text Data
0011-lisp-auth-source-pass.el-Version-5.0.0.patch
Description: Text Data
0012-etc-NEWS-Describe-changes-to-auth-source-pass.patch
Description: Text Data
[Prev in Thread] | Current Thread | [Next in Thread] |