bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#74848: [PATCH] calendar: check for presuppositions in `calendar-date


From: Richard Lawrence
Subject: bug#74848: [PATCH] calendar: check for presuppositions in `calendar-date-is-valid-p'
Date: Sat, 14 Dec 2024 13:19:19 +0100

Eli Zaretskii <eliz@gnu.org> writes:

> The commit log message should include the file and the function(s)
> where the changes are done, as well as a short description of the
> changes.  See CONTRIBUTE for more details, and see "git log" for the
> examples of how we format commit log messages.  Please don't forget to
> mention the bug number in the commit log message.

Woops, sorry, I did look at that file but I guess I missed that. New
patch attached.

> P.S. I presume you've run the relevant parts of the test suite and
> verified that they still succeed.  If not, please do.

Oddly enough, unless I'm missing something, there don't seem to be any
tests for calendar.el. There *are* a bunch of test files in
test/lisp/calendar, but they are all for other files, not for
calendar.el itself. The attached patch includes a new test file with a
basic test of the predicate, and make check reveals no relevant
problems.

Best,
Richard

Attachment: 0001-Check-for-presuppositions-in-calendar-date-is-valid-.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]