bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#74616: 30.0.92; tmm always displays the *Completions* buffer


From: Eli Zaretskii
Subject: bug#74616: 30.0.92; tmm always displays the *Completions* buffer
Date: Sat, 14 Dec 2024 14:40:12 +0200

> From: Daniel Mendler <mail@daniel-mendler.de>
> Cc: juri@linkov.net,  monnier@iro.umontreal.ca,  74616@debbugs.gnu.org
> Date: Sat, 14 Dec 2024 12:44:48 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> From: Daniel Mendler <mail@daniel-mendler.de>
> >> Cc: juri@linkov.net,  monnier@iro.umontreal.ca,  74616@debbugs.gnu.org
> >> Date: Wed, 11 Dec 2024 16:37:18 +0100
> >> 
> >> > Thanks.  This LGTM (but let's leave some time for others to chime in),
> >> > with the following nit:
> >> >
> >> >> ++++
> >> >> +*** New user option 'completion-eager-display'.
> >> >> +This option configures whether completion commands should display
> >> >> +the *Completions* buffer immediately.  When the variable is set to t 
> >> >> all
> >> >> +completion commands show *Completions* immediately, respectively nil
> >> >> +disables the eager display for all commands. The default setting auto
> >> >                                               ^^
> >> > Two spaces there, please.
> >> 
> >> Thanks. Updated patch attached.
> >
> > Thanks.  I was about to install this, but it turns out it breaks
> > minibuffer-tests:
> 
> Thanks for finding this. The problem was that `initial-input' was passed
> directly to `completion-metadata'. I replaced `initial-input' with `(or
> initial-input "")'. See the updated patch attached to this mail.

Thanks, now installed on the master branch, and closing the bug.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]