Re: PSPP-BUG: [bug #45325] Crash when opening URLS

[Ben Pfaff]

What do you think of the following proposed "fix" for the crash?

--8<--------------------------cut here-------------------------->8--

From: Ben Pfaff <address@hidden>
Date: Wed, 1 Jul 2015 09:49:07 -0700
Subject: [PATCH] gui: Disable website URL in GTK+3 before 3.15.5.

This prevents an otherwise unavoidable segfault in those versions.

Bug #45325.
---
 src/ui/gui/help-menu.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/ui/gui/help-menu.c b/src/ui/gui/help-menu.c
index 46d4032..9a42056 100644
--- a/src/ui/gui/help-menu.c
+++ b/src/ui/gui/help-menu.c
@@ -43,7 +43,10 @@ about_new (GtkMenuItem *mmm, GtkWindow *parent)
 
   gtk_window_set_icon_name (GTK_WINDOW (about), "pspp");
 
-  gtk_about_dialog_set_website (GTK_ABOUT_DIALOG (about), PACKAGE_URL);
+  /* In GTK+3 before 3.15.5, clicking on a URL in the About dialog caused a
+     segfault, so simply disable the feature for those earlier versions. */
+  if (!gtk_check_version (3, 15, 5))
+    gtk_about_dialog_set_website (GTK_ABOUT_DIALOG (about), PACKAGE_URL);
 
   gtk_about_dialog_set_version (GTK_ABOUT_DIALOG (about),
                                bare_version);
-- 
2.1.3