Crawford checkbox #65639 (was Preview of forthcoming gnubg release)

[TAKAHASHI Kaoru]

Hi,

TAKAHASHI Kaoru <kaoru-ml-gnubg@trans-nt.com> writes:
> Hi,
>
> Philippe Michel <philippe.michel7@free.fr> writes:
>> On Thu, Apr 25, 2024 at 05:17:06AM +0900, TAKAHASHI Kaoru wrote:
>>
>>> I found bug at Crawford checkbox (at `show marketwindow').
>>> <https://savannah.gnu.org/bugs/index.php?65639>
>>> 
>>> Might be better to merge after 1.08.003 release as it has not been
>>> tested enough.
>>
>> I will comment here rather than in the savannah bug tracker since list 
>> readers may want to get involved.
>>
>> Tha patch fixes inconsistencies between the score, the possible cube 
>> values and the Crawford game checkbox, but the latter doesn't really 
>> make sense in this part of the UI: if the cube is not usable there is no 
>> market window to investigate.
>>
>> The values displayed are at the post-Crawford score anyway. I would 
>> simply remove the checkbox. On the other hand, the non-greyed-out cube 
>> values are currently inaccurate (a little overextended).
>>
>> For instance if one player is at a 1-away score, the only useful cube 
>> value is 1 (it could be at 2, but then it would be owned by the 1-away 
>> player who will not consider doubling).
>
> If it were only for the marketwindow, I would be rather in favor of
> removing the checkboxes too.
>
> However, if the `gammon value' tab is used by beginners, it might be
> better to have the checkbox.  Because, expert player knows that the
> gammon-value does not change Crawford or post-Crawford centered cube,
> but a beginner may not.

In the long term, it may be a different changes at marketwindow.
(remove the checkbox, add non-gammon-adjust, ... etc)

But, Could you merge this crawford-checkbox fix for now?
(gziped format-patch attached)

The patch makes 1away-1away keeps crawford checkbox (XG2 style).

I'll attach the same format-patch to
<https://savannah.gnu.org/bugs/index.php?65639> later.
-- 
TAKAHASHI Kaoru

0001-Deactivate-crawford-checkbox-according-to-score-bug-.patch.gz
Description: application/gzip