[Bug-gnulib] Re: gnulib/lib error.c

[Jim Meyering]

>       (error_tail): Don't cast alloca to (void *); it's already (void *).

Thanks for doing that.
I've just removed a bunch of similar casts in coreutils/src/*.[ch]
and added another syntax-check rule to detect them.

I was tempted to remove all such casts from gnulib/lib, too,
but wonder if it's worth the hassle for files that come from glibc.
What do you think?

  pi$ grep -E '\) *alloca\>' *.[ch]
  fnmatch.c:      wpattern = (wchar_t *) alloca ((n + 1) * sizeof (wchar_t));
  fnmatch.c:      wstring = (wchar_t *) alloca ((n + 1) * sizeof (wchar_t));
  makepath.c:      dirpath = (char *) alloca (strlen (argpath) + 1);
  regex.c:  (destination = (char *) alloca (nsize),                             
\
  setenv.c:       new_value = (char *) alloca (namelen + 1 + vallen);
  strftime.c:    ws = (wchar_t *) alloca ((l + 1) * sizeof (wchar_t));          
      \
  userspec.c:      (dest) = (char *) alloca (_len + 1);                         
\
  vasnprintf.c:      (char *) alloca (7 + d.max_width_length + 
d.max_precision_length + 6);