Re: relocatable-prog missing dependency to alloca

[Bruno Haible]

Sylvain Beucler wrote:
> Missing dependency: I imported the 'relocatable-prog' module in an
> empty project. It lacked the 'alloca' module dependency (although it
> imported 'alloca-opt'):
> 
> $ sh bootstrap
> + autoreconf --install --symlink --warnings=all
> /usr/share/aclocal/smpeg.m4:13: warning: underquoted definition of 
> AM_PATH_SMPEG
>   run info '(automake)Extending aclocal'
>   or see http://sources.redhat.com/automake/automake.html#Extending-aclocal
> configure.ac:18: error: missing gnulib/lib/alloca.c
> gnulib/m4/gnulib-comp.m4:110: gl_LIBSOURCES is expanded from...
> ../../lib/autoconf/functions.m4:348: AC_FUNC_ALLOCA is expanded from...
> gnulib/m4/alloca.m4:7: gl_FUNC_ALLOCA is expanded from...
> gnulib/m4/gnulib-comp.m4:33: gl_INIT is expanded from...
> configure.ac:18: the top level
> autom4te: /usr/bin/m4 failed with exit status: 1
> aclocal: autom4te failed with exit status: 1
> autoreconf: aclocal failed with exit status: 1

Whoops. Actually the 'alloca-opt' module is broken:
  ./gnulib-tool --create-testdir --dir=... alloca-opt
gives an error message. ('alloca-opt' does *not* need alloca.c.)

It was broken three days ago. I'm fixing it like this:


2007-10-01  Bruno Haible  <address@hidden>

        * gnulib-tool (func_emit_initmacro_done): Special case for alloca.c.
        Needed for the alloca-opt module.

*** gnulib-tool.orig    2007-10-02 01:09:57.000000000 +0200
--- gnulib-tool 2007-10-02 01:07:43.000000000 +0200
***************
*** 1950,1962 ****
    echo "  AC_CHECK_FUNCS([\$1], , [${macro_prefix}_LIBOBJ(\$ac_func)])"
    echo "])"
    echo
!   echo "# Like AC_LIBSOURCES, except check for typos now."
!   echo "# We rely on EXTRA_lib..._SOURCES instead."
    echo "AC_DEFUN([${macro_prefix}_LIBSOURCES], ["
    echo "  m4_foreach([_gl_NAME], [\$1], ["
!   echo "    m4_syscmd([test -r $sourcebase/]_gl_NAME[ || test ! -d 
$sourcebase])dnl"
!   echo "    m4_if(m4_sysval, [0], [],"
!   echo "      [AC_FATAL([missing $sourcebase/]_gl_NAME)])"
    echo "  ])"
    echo "])"
  }
--- 1950,1966 ----
    echo "  AC_CHECK_FUNCS([\$1], , [${macro_prefix}_LIBOBJ(\$ac_func)])"
    echo "])"
    echo
!   echo "# Like AC_LIBSOURCES, except the directory where the source file is"
!   echo "# expected is derived from the gnulib-tool parametrization,"
!   echo "# and alloca is special cased (for the alloca-opt module)."
!   echo "# We could also entirely rely on EXTRA_lib..._SOURCES."
    echo "AC_DEFUN([${macro_prefix}_LIBSOURCES], ["
    echo "  m4_foreach([_gl_NAME], [\$1], ["
!   echo "    m4_if(_gl_NAME, [alloca.c], [], ["
!   echo "      m4_syscmd([test -r $sourcebase/]_gl_NAME[ || test ! -d 
$sourcebase])dnl"
!   echo "      m4_if(m4_sysval, [0], [],"
!   echo "        [AC_FATAL([missing $sourcebase/]_gl_NAME)])"
!   echo "    ])"
    echo "  ])"
    echo "])"
  }