[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] stdlib: support non-GCC __attribute__
From: |
Jim Meyering |
Subject: |
Re: [PATCH] stdlib: support non-GCC __attribute__ |
Date: |
Mon, 14 Feb 2011 08:35:01 +0100 |
Bruno Haible wrote:
> Paul Eggert wrote:
>> > Here's a proposed patch.
>>
>> That looks good as far as it goes,
>
> OK, here's a revised patch. Avoids the #ifndef now, and includes some
> tests/*.c
> files.
>
>> but while we're at it,
>> shouldn't we use a consistent naming convention?
>> It's confusing that one .h file uses _GL_ATTRIBUTE_NORETURN and
>> another uses ATTRIBUTE_NORETURN, for the same notion.
>
> Good point. Here's a patch to rename these macros, so that they use the
> _GL_ prefix which we agreed a couple of months ago is the least risky.
>
> Objections to these patches? Jim? Paul?
...
> Subject: [PATCH 1/2] Don't interfere with a program's definition of
> __attribute__.
> Subject: [PATCH 2/2] Consistent macro naming for macros that use GCC
> __attribute__.
Fine by me. I'll test once you push.
Thanks!
- [PATCH] stdlib: support non-GCC __attribute__, Paul Eggert, 2011/02/12
- Re: [PATCH] stdlib: support non-GCC __attribute__, Bruno Haible, 2011/02/13
- Re: [PATCH] stdlib: support non-GCC __attribute__, Paul Eggert, 2011/02/13
- Re: [PATCH] stdlib: support non-GCC __attribute__, Bruno Haible, 2011/02/13
- Re: [PATCH] stdlib: support non-GCC __attribute__,
Jim Meyering <=
- Re: [PATCH] stdlib: support non-GCC __attribute__, Paul Eggert, 2011/02/14
- Re: [PATCH] stdlib: support non-GCC __attribute__, Bruno Haible, 2011/02/14
- Re: installable stdlib.h, Bruno Haible, 2011/02/13
- Re: installable stdlib.h, Paul Eggert, 2011/02/13