Re: [PATCHv2 1/2] grantpt: only build pt_chown when needed

[Bruno Haible]

Hi Eric,

>  2011-10-19  Eric Blake  <address@hidden>
> 
> +     grantpt: only build pt_chown when needed
> +     * modules/pt_chown: Delete, merging into...
> +     * modules/grantpt: ...its sole user.  Make building of pt_chown
> +     depend on an automake conditional.
> +     * gnulib-tool (func_get_automake_snippet_unconditional): Alter
> +     special-casing of pt_chown.c.
> +     * NEWS: Document the change.

I completely disagree with this change. grantpt and pt_chown live in
different *programs*, link with different libraries, and are run at
different *security levels*. It MUST be possible to write these as
separate modules.

In particular, your patch would make it impossible to build 'grantpt'
in one directory and 'pt_chown' in a different directory (under the
scope of a different gnulib-tool invocation).

The --conditional-dependencies feature was designed to avoid hacks
like this.

Did you try to use this option? Does it not work?

Bruno
-- 
In memoriam Eduard Brücklmeier <http://en.wikipedia.org/wiki/Eduard_Brücklmeier>