[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: pt_chown linking
From: |
Bruno Haible |
Subject: |
Re: pt_chown linking |
Date: |
Thu, 20 Oct 2011 11:09:53 +0200 |
User-agent: |
KMail/1.13.6 (Linux/2.6.37.6-0.5-desktop; KDE/4.6.0; x86_64; ; ) |
Eric Blake wrote:
> > CCLD libgnu.la
> > CC pt_chown.o
> > make[4]: *** No rule to make target `libgnu.a', needed by `pt_chown'. Stop.
> >
> > Looks like the gnulib-tool output is not considering the possibility of
> > libtool mixing with the creation of pt_chown.
>
> Changing pt_chown to not require libgnu.a in any form would be one
> solution
That is not the solution. There is a comment in lib/pt_chown.c
/* For security reasons, we try to minimize the dependencies on libraries
outside libc. This means, in particular:
- No use of gettext(), since it's usually implemented in libintl.
- No use of error() or argp, since they rely on gettext by default. */
And what you want to do, is to install libgnu.so as a shared library,
and pt_chown that links with it.
I would not do that, for security reasons.
Instead, if your main gnulib-tool invocation is with --libtool,
use gnulib-tool a second time, without --libtool and just just one
module: 'pt_chown'. This way, you can have a setuid executable that
does not link against shared libraries except libc, and it contains
the minimal needed code (basically only pt_chown.c, ptsname.c, and
ttyname_r.c).
Bruno
--
In memoriam Eduard Brücklmeier <http://en.wikipedia.org/wiki/Eduard_Brücklmeier>
- license relaxation request, Eric Blake, 2011/10/17
- Re: license relaxation request, Bruno Haible, 2011/10/17
- Re: pt_chown build failure, Bruno Haible, 2011/10/19
- Re: pt_chown build failure, Eric Blake, 2011/10/19
- [PATCHv2 1/2] grantpt: only build pt_chown when needed, Eric Blake, 2011/10/19
- [PATCHv2 2/2] pt_chown: break gnulib link dependency, Eric Blake, 2011/10/19
- Re: [PATCHv2 2/2] pt_chown: break gnulib link dependency, Bruno Haible, 2011/10/20
- Re: [PATCHv2 1/2] grantpt: only build pt_chown when needed, Bruno Haible, 2011/10/20
- Re: license relaxation request, Bruno Haible, 2011/10/19
- Re: license relaxation request, Eric Blake, 2011/10/19
- Re: license relaxation request, Simon Josefsson, 2011/10/20