Re: [PATCH] tests: factor st_ctime-comparison out of two headers

[Jim Meyering]

Bruno Haible wrote:

> Jim Meyering wrote:
>> +static inline int
>> +ctime_compare (struct stat const *a, struct stat const *b)
>
> This code uses 'inline'. But the module descriptions
>   modules/fdutimensat-tests
>   modules/futimens-tests
>   modules/utimens-tests
>   modules/utimensat-tests
> don't contain an AC_REQUIRE([AC_C_INLINE]).

True, but...

> The simplest fix for this, IMO, would be to remove the 'inline' keyword.
> This part of the tests is not speed critical.

Speed was never the issue, for me.
If we drop the "inline", then any compilation unit that includes
that header without using the function will get a warning about
the unused static function.

Each of those four modules already depends on the ignore-value
module which does happen to AC_REQUIRE([AC_C_INLINE]), so in a
sense no change is required.  These are only test modules after all.

However, I will add the four AC_REQUIRE lines.