[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] version-etc.c: Do not include URLS in translatable strings.
From: |
Ben Pfaff |
Subject: |
Re: [PATCH] version-etc.c: Do not include URLS in translatable strings. |
Date: |
Mon, 6 May 2019 11:43:49 -0700 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Mon, May 06, 2019 at 08:21:34PM +0200, John Darrington wrote:
> This method is better for several reasons: 1. It avoids the danger of
> cut and paste errors. 2. Naive translators can't translate the urls
> (it's amazing how many do things like that!) 3. Should the urls ever
> change, only this file has to be updated rather than every single
> translation.
>
> * lib/version-etc.c: Take URLS out of translatable strings.
> ---
> lib/version-etc.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/lib/version-etc.c b/lib/version-etc.c
> index 9ca9a5628..4a060e0b5 100644
> --- a/lib/version-etc.c
> +++ b/lib/version-etc.c
> @@ -82,14 +82,13 @@ version_etc_arn (FILE *stream,
> locale. Otherwise, do not translate "(C)"; leave it as-is. */
> fprintf (stream, version_etc_copyright, _("(C)"), COPYRIGHT_YEAR);
>
> - fputs (_("\
> + fprintf (stream, _("\
> \n\
> -License GPLv3+: GNU GPL version 3 or later
> <https://gnu.org/licenses/gpl.html>.\n\
> +License GPLv3+: GNU GPL version 3 or later <%s>.\n\
Does anyone ever try to translate the "GPLv3+" part? If so, then it
could be taken out as well.